Comments (14)
Yes, I guess it's time to change the behaviour for embedded cover art, there was already similar requests in the past. External cover art should not be affected by this, it's always part of the album.
from winyl.
Changed. There is still a possibility to cover art stuck when an user has tracks with embedded cover arts + tracks without embedded cover arts + random jpeg/png files in one folder.
But to fix this the optimization for huge external cover arts should be completely removed. I don't want to do that and I don't believe any user have such a mess in one folder.
from winyl.
I downloaded the first 3 files and can't reproduce the issue. Are you sure you compiled the latest master branch?
Here I compiled the master to try:
Winyl.zip
Let me know if it still doesn't work.
from winyl.
Good to know that it works fine. By the way, you can set different album names for these files if you want to ungroup them to display different cover arts in the list.
from winyl.
From your video, it seems that you might be using a third-party skin in Winyl ? Does the issue occur when you use a different skin (third-party or native) ?
The described issue does not occur in my Winyl (current v3.3 & recent older versions) using a native skin. In other words, if the tracks have their own embedded album art, Winyl correctly displays the album art as embedded in the respective tracks.
From observation, the only situation (#9 ) where Winyl (current & older versions) repeatedly displays the same album art occurs only under the following conditions:-
- The played-back tracks have no embedded album art.
- The main folder imported as playlist contains at least 1 standalone image file.
In the above situation, Winyl keeps using the first-listed (& possibly unrelated) image file as album art for all tracks lacking embedded album art. Tracks with embedded album art are displayed correctly.
from winyl.
@hairycactus okay, I'll try with the skin disabled! Hopefully it would be possible to invert a fix/workaround for my issue even with this skin applied..?
On the counter part for testing, here is the skin I use: https://pep0.deviantart.com/art/Material-Light-and-Dark-for-Winyl-8-colors-597613989
from winyl.
I think it's because the cover art is a part of album right now, so it only changes when the album name or the folder of the track changed.
Are these files part of one album? If yes is there a reason why they have different cover arts?
from winyl.
@hairycactus it's independent of the theme
@alexkx then it would have to be changed to be a part of the song. Those files are part of the same folder but none of them has an album defined in the ID3-tag. And ofc there's a reason, all those songs and many, many more are downloaded from youtube playlists, the CoverArts are the youtube thumbnails. I also spend quite a time to assign songs of such compilations CoverArts when they didn't fit/didn't have one, so it's pretty annoying to me to not see the correct one for each song.
from winyl.
really nice, thanks for the fast implementation!
from winyl.
@alexkx I downloaded the current repo and compiled it myself, but I still have this problem. Shouldn't the ZIP download of the whole repo already include the CoverArt fix? Because it's listed in the CHANGES.md "- Changed behaviour when reloading cover arts."
from winyl.
It does include the fix. Do you have any image files in the folder with your music files?
from winyl.
@alexkx no I haven't (as you mentioned, it would cause this bug). To make further trouble shooting easier, I'm sharing a folder with you whith songs which are affected by this bug: https://homedrive.zapto.org/nextcloud/index.php/s/C5GddG63KC2ZEDa (it's the same folder as shown in the example video in the OP)
an idea which just came to my mind: I'm sharing the folder from my DIY Sever/NAS which hosts nextcloud but also stores all music. I've mapped a network share as drive in Windows and added my Music folder to the library of Winyl (so maybe UNC shares are causing a problem?)
from winyl.
@alexkx thank you for the application! Tbh it seems it was my fault, I was looking at the Album Cover Art, not Song Cover Art (after compiling I tested it out with the default Winyl design but because I'm usually using a different one I looked at the wrong Image).
So you can leave this issue closed by good, I'm looking forward to the official 3.4 release! :D
Thank you for your hard work and I'm really sorry I reported a non-existent issue
from winyl.
@alexkx yes but I don't wanna spam my artists section :p
from winyl.
Related Issues (20)
- Add per-track volume or volume leveling HOT 2
- This is the end? HOT 4
- Ability to disable fade in/out on playback and seek HOT 2
- Search not Working HOT 3
- How Do I Save My Playlists in Winyl? HOT 1
- Screensaver HOT 1
- Will there be player support? HOT 8
- Linux version HOT 1
- Status bar - top right : Total time HOT 1
- Folder view HOT 3
- Webserver HOT 1
- Album art HOT 3
- Errormessage HOT 1
- No output (sound) HOT 3
- Some wav files don't display duration
- Duplicate results in search when search term is in multiple metadata fields of the same track
- Resume play on startup argument
- Bitrate HOT 1
- Crossfade feature
- Miscellaneous questions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from winyl.