GithubHelp home page GithubHelp logo

Comments (3)

alexkx avatar alexkx commented on May 27, 2024

Actually, this behaviour was different in earlier versions. But many users reported that Winyl doesn't show the cover art, because they have the cover art in png/jpeg file with some random name. So the behaviour changed.

Winyl should not by default display any image for tracks without embedded album art.

It's impossible, many users use external cover art. It must be by default.

Also Winyl doesn't grab just the first image file. It uses the following algorithm:

  1. Search for jpeg/png file with name that contains "Front" or "Cover"
  2. Read the cover art from tags
  3. Search for jpeg/png file with name "Folder"

If all steps fail then use 1st jpeg/png file.

from winyl.

hairycactus avatar hairycactus commented on May 27, 2024

Thanks for explaining the logic of how Winyl selects images for display as album art. It would be good to include such info in a wiki section somewhere. I don't see such a wiki section here at Github, the Winyl website, or its forum.

But many users reported that Winyl doesn't show the cover art, because they have the cover art in png/jpeg file with some random name. So the behaviour changed.

The issue about the current logic is that it makes Winyl's behaviour appear strange & even haphazard to:

  1. Users who are meticulous about naming standalone image files (if any) to precisely match the album's or track's filename;

  2. Users who have named standalone image files by another standardized name (eg. AlbumArt, AlbumCover, CoverArt, Art, etc.).

Winyl should not by default display any image for tracks without embedded album art.

It's impossible, many users use external cover art. It must be by default.

There are also users who deliberately do not wish to use any embedded or external album art for certain tracks. Examples of such tracks could be ambient sounds or lecture recordings. It isn't meaningful to use any album art for such tracks.

And the default of forcing an unrelated image to be used as album art for cover-lesss tracks is visually misleading, making users do a double-take & wonder if the correct track has been selected for playback.

Perhaps the below suggestions might cater to a broader range of user preferences ?

  1. Provide users with an option whether to use standalone image files as album art for tracks without embedded covers.

  2. Allow users to optionally choose their preferred standardized name for standalone image files to be used as album art, other than Winyl's current defaults of Front or Cover.

  3. Allow users (especially those who use random filenames for standalone images) to optionally tell Winyl where to look for standalone image files, such as inside one or all of the following folders:

    • Audio track's folder
    • Parent folder
    • Subfolder -- user is to specify subfolder name, eg. AlbumArt (besides Winyl's current generic default of Folder).

Thanks !

from winyl.

alexkx avatar alexkx commented on May 27, 2024

Users who have named standalone image files by another standardized name (eg. AlbumArt, AlbumCover, CoverArt, Art, etc.).

This is exactly the reason, there isn't any standardized name for a cover art. Many people just download a cover art from the Internet drop it into the folder and that is all, the name can be random.

There are also users who deliberately do not wish to use any embedded or external album art for certain tracks. Examples of such tracks could be ambient sounds or lecture recordings. It isn't meaningful to use any album art for such tracks.

Then why there are random image files in this folder? And I don't see a problem just to add a neutral cover.jpg file to the folder in this case.

Allow users (especially those who use random filenames for standalone images) to optionally tell Winyl where to look for standalone image files, such as inside one or all of the following folders:

This option will be used by a couple of users only, believe me.

If someone wants to implement it, feel free.

from winyl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.