wixel / codeigniter-assetloader Goto Github PK

Presently there is no such method that allow developers to render CSS and JavaScript tags at different places. For some reason developers might want to insert CSS tags in HEAD tag and JavaScript tags before closing body tag. This library should provide this functionality out-of-the-box.

Hi,

Your library is super useful and awesome. I would like to contribute. I think for this todo item we should introduce a new syntax. For example:

js[]  = ["src" => "js/vendor/modernizr-2.6.2.min.js", "attributes" => ["async" => true, "custom-attribute" => "custom-attribute-value"]];

This syntax will not add much complexity as PHP developers are already familiar with associative arrays. For other resources which don't require any extra attributes existing syntax i.e. js[] = "js/vendor/modernizr-2.6.2.min.js" will work fine.

Please let me know what you think and I would love to contribute.

Thanks.

Presently if I mention same file multiple times in .ini file then same tag for that file is getting inserted multiple times. Even if I mention same file multiple times under same environment it's tag should be inserted once.

Presently for CSS and JavaScript tags, path is generated like <script src='/assets/js/application.js'></script>. This path restrict browsers to fetch resources from root. Many a times during local development most developers don't create virtual-host and prefer to run web-apps under some directory in web-root which creates path like http://localhost/my_web_app. Inserting / before paths makes it difficult for those developers to use this library.

A clean way to achieve abstraction is to use CodeIgniter's built-in site_url method to generate path for assets. This will create correct path in every case.