GithubHelp home page GithubHelp logo

Unsanitized filenames about gdown HOT 4 OPEN

OmarAHex avatar OmarAHex commented on June 4, 2024 1
Unsanitized filenames

from gdown.

Comments (4)

OmarAHex avatar OmarAHex commented on June 4, 2024 1

Another note, google drive allows slashes in file names, meaning by the time the download function receives the output path it is impossible to tell whether that slash is part of a file name or represents a folder, so atleast some part of the sanitization would need to happen in the download_folder file. (The error raised here is related to trying to write to a nonexistant folder)

from gdown.

OmarAHex avatar OmarAHex commented on June 4, 2024

Also, line 185 in download_folder.py does "file.name.replace(osp.sep, '_')"
but this is not sufficient for windows
on windows, osp.sep is "\", but "/" is also a valid separator, which gdown ignores, I think this entire issue could be resolved by replacing that line of code with a proper sanitization function

from gdown.

wkentaro avatar wkentaro commented on June 4, 2024

@OmarAHex Can you give me an example so that I can reproduce?

from gdown.

OmarAHex avatar OmarAHex commented on June 4, 2024

https://drive.google.com/drive/folders/12cQ4ltgbkBhltqylzSg7g0n7lcTV8zew

from gdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.