wobbley / hots-willie-module

A module for Willie The IRC Bot for heroes of the storm

Hello there 👋

Most of my contributions are to private repositories, but feel free to look around. If you want to reach out for whatever reason it's probably best to use LinkedIn.

hots-willie-module's Issues

!tips without a space gives an error

04:09:47 @keNzi !tips
04:09:47 <+Hotsbot> AttributeError: 'NoneType' object has no attribute 'replace' (file "/home/ubuntu/.willie/modules/hots.py", line 57, in tips)
04:09:49 @keNzi !tips
04:09:49 <+Hotsbot> Tips can be found here: http://heroesofthestorm.github.io/tips

All BattleTags in database.

Create a command that displays all BattleTags in the database and the corresponding IRC username, perhaps as PM.

the errors with accents éàä etc

08:02:06 !rating kenzi
08:02:08 <+Hotsbot> AttributeError: 'NoneType' object has no attribute 'previous_sibling' (file "/home/willie/.willie/modules/hots.py", line 93, in hotslogs_rating)

happens because of the Kénzi guy, is that easily fixable?

!rating is not working properly

Hotslogs has changed, if it only finds one player with the given name it will immediately show that player, hence there will be no table to retrieve the MMR from.

!addbt doesn't accept 5 numbers

03:31:23 !addbt nate#11939 us
03:35:34 does it not think bts can have 5 numbers? or am I getting the region wrong? or just missing something stupid? also tried na and americas.

limit the result of !rotation to 7

sometimes the guy of http://heroesofthestorm.github.io/free-hero-rotation leaves the heroes of the previous week in there for a few hours/days
maybe you can adapt the bot so that it only prints 7 names, instead of all the ones on the page?

07:36:56 !rotation
07:36:56 <+Hotsbot> Free rotation: Arthas, E.T.C, Kerrigan, Li Li, Nazeebo, Tychus, Uther, Falstad, Malfurion, Sonya, Stitches, Valla, Sergeant Hammer, Brightwing

Bug with !rating

Ravilan: !rating Ravilan
Hotsbot: AttributeError: 'NoneType' object has no attribute 'previous_sibling' (file "/home/ubuntu/.willie/modules/hots.py", line 96, in hotslogs_rating)

Make the bot say that he is going to update

We may use github webhooks

See: https://github.com/theonion/willie-modules/blob/master/webhook.py

The goal would be to have bot launch a webserver, and before restarting the bot, jenkins would curl to that webserver. This way whenever the bot receive a message on this webserver, it means that he is gonna be updated, so it can say "Brb, updating" or something.

• Add the code
• Configure jenkins to send a POST call on build

Make !ts call the same command as !ts3

It's an easy fix, I will just do it directly in github if possible

Rename some stuff to be closer to real use case

For example, the main command should be addbt and the alias addBattleTag as addbt remain the most used one.

This is just for code readability and understanding.

Brand new bot?

So… as you know I've started to play with IRC bots in ruby, and I've almost finished a Hotsbot clone in ruby, but this one is: tested, has (almost) complete docs, is imo more maintainable (we can split code into files, tests are made easy) and is based on a bot framework having a good documentation (I'm looking at you willie)!

So the question is: would you guys be ok with kicking out the bot based on willie and replace it with this one?

Sources can be found here: https://github.com/chadrien/hots-irc-bot

Authentication

Make the bot autoauth

discussion about an hotslogs api

Hey guys,

Our very own Karti gave me an idea that would give more diversity to our lovely bot.

We could ask Ben (hotslogs dev) to write up an API so that we can pull every single stat that is available on hotslogs.com to give us new options like !winrate, !ratingQM, !ratingHL or whatever you can think of.

Now, it seems like he has evaded the question when Karti asked him so I need your help here to write up some arguments as to why he should do that, what all the advantages are, what can be built with it etc

Thoughts, friends? :)

Better docs

Docs were made in a hurry, improve them so they are more clear and easy to understand

Add a command like this ??addbt <user> to highlight the user with an explanation on how to add his infos

Would do something like this :
hotsbot: Wobbley, you can add your battle.net infos like this !addbt /tag/ /region/

But automatically!

you're welcome

!rotation seems bugged

Maybe we should add a fallback: if the list is empty, print the URL instead

make the bot PM the link of the !rating pull

15:47:32 Here's the full list of your request: https://www.hotslogs.com/PlayerSearch?Name=Flash

Create an auth command that can be used to let willie auth with the server

And admin command to let willie auth with the server, also set mode as +X. Make sure perhaps that it does not do it multiple times?

!addbt with no parameters

StroggCake: !addbt
Hotsbot: TypeError: expected string or buffer (file "/home/willie/.willie/modules/hots.py", line 137, in assign_bnet)

Remove URL titles

No need for the bot to re-print the pasted URL.

pull the !rotation info from somewhere else

as Heroesfire appeared to be extremely slow ( 2 days to update the rotation) maybe it's a better idea to pull the info from http://heroesofthestorm.github.io/free-hero-rotation ? iirc it's updated much faster than heroesfire is
don't know if it's possible, me very dump

wrong format when !addbt with number

19:56:39 !addbt k1rby#2907 EU
gives
19:57:56 [BattleTag]: Wrong format, an example of the correct format: "!addBT Wobbley#2372 EU"

add a basic !help command

should add a !help command because that's the first thing people try to do, instead of typing !commands or even reading the topic : o)

it should say something like
Hotsbot: "Hey [name]! Check out my !commands to see what I can do"

thoughts?

Add unit testing

See https://github.com/embolalia/willie/wiki/Examples-and-units-tests

Remove blank space when a name is requested in !getBT

Set a limit to what !rating displays because otherwise it gets kicked for excess flood

12:11:40 ⇐ +Hotsbot quit (~[email protected]) Excess Flood

Create a !bug command

Hide players without rating from the list?

HotSBotRavilan: Kenzi [EU] - [2185]
HotSBotRavilan: Kenzi [US] - [ ]
HotSBotRavilan: Kénzi [EU] - [ ]
HotSBotRavilan: Kenzi [EU] - [ ]
HotSBotRavilan: KENZI [KR] - [ ]

In this case, only display the first one, ignoring the rest of it.

Also, league seems to be broken, maybe remove it from the list?