Problem exporting to WOPN format about opn2bankeditor

[Wohlstand]

Which GEMS bank? Any?
It's possibly some invalid data was written and reader was confused...

[Wohlstand]

Oh! Yeah, the GEMS banks are usually melodic only, and there are lacks percussions. WOPN requires to have 128:128 set as minimum. So, the WOPN needs to have one blank drums set while saving.

[jpcima]

As I was able to see, on import of the GEMS bank, the editor is displaying some garbage on the percussion side. Clearly, the editor does not appear happy to lack having an empty drum bank.

[Wohlstand]

Oh, yeah, while filling the bank, you need to initialize the container to let it have blank 128:128 entries set. And, while saving the bank, it's need to guarantee the saving bank will have minimal 128:128.

Anyway, try to put break point and check, which part of WOPN parser makes "bad format"?

[jpcima]

I had it at this point in code, happening inside readInstrument.

        FmBank::Instrument &ins = (readPercussion) ? bank.Ins_Percussion[i] : bank.Ins_Melodic[i];
        if(!readInstrument(file, ins, version))

About gems, I believe it was a matter of writing this fix. I will check if new banks are working.

-    bank.reset(bankCount, 0);
+    bank.reset(bankCount, 1);

[jpcima]

The banks work! I updated a bank package into VST (btw, now having full OPN2 and ready builds 👍 )
PR will follow quickly