wolfgangdrescher / intonation-grid-bundle Goto Github PK

To follow the naming conventions of symfony 4 it could be helpful to rename the class names of rezent/prezent-grid.

• Abstract classes have a Base prefix instead of Abstract
• Interfaces have no Interface suffix
• Classes implementing interfaces have Default prefix.

For clarity it could be worth to get rid of the prezent/prezent-grid dependency and implement it in this repository.

Add a class to guess a matching ElementType/ColumnTyp for all properties of an entity and implement it into GridService. With this method it will no longer be needed for easy entities to create custom GridTypes.

Parse the ORM configuration, type hints or the @var annotation to make a good guess.

The GridService::getPaginatedData method should only allow sorting on columns where the sorting was enabled with the sortable option.

When a pagination limit is set that is not displayed as an option in the select field HTML will always select the first option.

In general this feature should be improved. Maybe change it to an input field? Limit lower and upper bound for the limit value.

Add an extension for all suitable ElementTypes to search and filter for a query in a column.

An exception in thrown if one filters on a column of a CollectionType. Fix with a property path or some doctrine magic.

Create demos for some basic sample applications of this bundle. Also link to the documentation of prezent/grid and prezent/grid-bundle.

Add unit test for all relevant functions and methods.

Since it looks like Pagerfanta will be unmaintained it could be worth to get rid of this dependency. Instead Doctrine Pagination could be an option.

https://github.com/symfony/demo/blob/master/src/Pagination/Paginator.php

• NumberType
• ImageType
• MoneyType

• Set up query parameters for sort field and direction
• Add a parameter for a dynamic limit query parameter