wolfhong / lunarcalendar Goto Github PK

Hello,

The library imports itself in its setup.py: here
Usually it shouldn't import a package during the bootstrap of the build of that package.
To import itself, the package must have all its dependencies already present in the virtualenv before it starts building.

Could you change to a better way to get that version string and update pypi?
For example, put it in a different file that does not import other dependencies, and import that.

Thanks

modifing in festival.py is ugly. More elegant.

add supports for 24-solar-terms

I try this and the algorithm gives me the wrong output:
print(Lunar.from_date(datetime.date(2021, 1, 4))) --> Lunar(year=2020, month=11, day=21, isleap=False)

It should be: Lunar(year=2020, month=11, day=22, isleap=False)

>>> festival.NewYearEve(2018)
>>> 2019-xx-xx

希望改为国历标准，而不是农历标准

清明不是一个固定的日子，原代码出错了。原来参考中华民国规定了4.5日为清明节，碰巧遇到2018年也是4.5号，因此弄错。

该bug需要在24节气的功能基础上完成。

add supports for HK, Taiwan