wonrax / mybk-mobile

Mybk Android app for HCMUT students.

Ha Huy Long Hai
Software Engineer

mybk-mobile's Issues

Empty screen when there's no data presence

The app currently doesn't show anything upon no data presence. We should display some message to inform the user that the data is not available (e.g. "No data is retrieved").

The app inaccurately parses the last update date

Probably due to improper testing or they have changed the date to a new format.

User's data still remains after logged out

Step to produce:

1. Login, retrieve user data successfully
2. Logout, log in with a new user
3. Retrieve data unsuccessfully (could be a network problem), the app shows the previous user's data

Consider better telemetry and feedback

I literally have no idea how the app is being used, apart from statistics on Google Play Console that tells me how many active users there are monthly or daily (DAU barely works), how many people have installed and uninstalled the app and some other device hardware and software metrics.

Also no one has filed an issue on GitHub. Does that mean my app has no bugs? But the dashboard shows 1.11% User-perceived crash rate. So maybe a better crash report could help?

I'm considering Firebase Analytics and Firebase Crashlytics since they're popular and completely free of charge.

Useful resource:

• research!rsc: Transparent Telemetry for Open-Source Projects

Multilanguage support (localization)

The Vietnamese texts are currently hard-coded in the source code. I don't know if we should support other languages since I think most students in our school (even foreigners) already know the most basic Vietnamese (to work and live in Vietnam, of course, however it's just my very subjective assumption).

Messages and Notifications Sections

Please add View Messages and Notifications features to the app. This certainly will help a lot.

Warning `Content padding parameter it is not used` when using Scaffold

Despite the warning, the UI still looks fine. But I want to make sure I use the Scaffold correctly and remove the warning. Scaffold docs

fun MybkUI(mainActivityViewModel: MainActivityViewModel) {
    MybkTheme(false) {
        val appState = rememberMybkAppState()

        val navController = appState.navController

        Scaffold(
            scaffoldState = appState.scaffoldState,
            snackbarHost = { CustomSnackbarHost(it) },
            bottomBar = {
                AnimatedVisibility(
                    appState.shouldShowBottomBar,
                    enter = slideIn { IntOffset(0, 250) },
                    exit = slideOut { IntOffset(0, 250) }
                ) { BottomNavigation(navController) }
            }
        ) { // it: PaddingValues <- Content padding parameter it is not used
            Box(
                modifier = Modifier
                    .background(Color.Grey10)
                    .fillMaxSize()
            ) {
                Navigation(navController, mainActivityViewModel)
            }
        }
    }
}

Remove Accompanist's system UI controller

Accompanist's system UI controller is deprecated. We have been using this to change the status bar color across routes.
https://google.github.io/accompanist/systemuicontroller/

They recommends using androidx.activity.ComponentActivity.enableEdgeToEdge, but it's only available in 1.8.0-beta01.

Considering Material 3

Material 3 has been available in Jetpack Compose. This issue is to track the research and investigation of integrating M3 into Mybk Mobile.