woochanlee / balancetetris Goto Github PK

The control block imported from the shift block was not in place.

Not be played shift sound at first shift(just after reloading the page).

The previous renderer was simply worked as full-drawing so It may not need the renderer module.

However, our optimization works show the increment of complexity.
Also, The maintenance fee will possibly increase when the optimization or something is added to the rendering system.

Therefore, I propose the renderer module which receives the blocks array, check difference previous rendered status, and render the blocks optimally.

It will increase maintainability, readability, possibly performance.

This issue discussed before.
#10 (comment)

But it is currently reproduced again in develop branch.

Please check this. @DevSDK

When the overflow occurred, the viewport is affected by keyboard events.
I think this behavior is not the expected result.
So this might be needed disable scrolling by keyboard.

Please see follow figure:

There might be one more contributor in this project, but I couldn't find him on README.md file.

Hope you guys add his profile.

1. The block doesn't align with the grid. Tetris block should be moved down and right by the half of the grid line width.

2. The font of the speed and score are weird. It would be great if you match them to the font of the title.

3. The temporary storage circle and the next Tetris block circle should be different. It is difficult to recognize the difference while we are playing.