woocommerce / storefront-footer-bar Goto Github PK

CSS 4.23% JavaScript 5.95% PHP 89.82%

storefront-footer-bar's Introduction

=== Storefront Footer Bar ===
Contributors: woocommerce,automattic,jameskoster,woothemes
Tags: woocommerce, ecommerce, storefront, footer, widgets
Requires at least: 4.1
Tested up to: 4.9
Stable tag: 1.0.4
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Add a full width widgetised region above the default Storefront footer widget area.

== Description ==

A simple plugin that adds a full width widget region above the default, columnised Storefront footer widget area. Customise the display by adding a background image and tweaking colors via the Customizer.

This plugin requires the Storefront theme to be installed.

== Installation ==

1. Upload `storefront-footer-bar` to the `/wp-content/plugins/` directory
2. Activate the plugin through the 'Plugins' menu in WordPress
3. Configure the display in the Customizer (look for the 'Footer Bar' section).
3. Done!

== Frequently Asked Questions ==

= I installed the plugin but cannot see the footer bar =

This plugin will only work with the [Storefront](http://wordpress.org/themes/storefront/) theme.

== Screenshots ==

1. The Footer Bar with a text widget.

== Changelog ==

= 1.0.4 - 12.10.2018 =
* Fix - Do not set the background-image property when no background image is defined. Kudos [@bobbingwide](https://github.com/bobbingwide).

= 1.0.3 - 03.04.2016 =
* Fix - Defaults not being set on activation.

= 1.0.2 - 03.03.2016 =
* Tweak - Code tidy up and tweaked how defaults are set.

= 1.0.1 - 06.23.2015 =
* Fix - Storefront install prompt no longer installs a child theme.

= 1.0.0 - 04.01.2015 =
Initial release.

storefront-footer-bar's People

Stargazers

Watchers

Forkers

lucspe bobbingwide collabsoft nielslange isabella232

storefront-footer-bar's Issues

.bind() jquery calls are being deprecated

The .bind calls within the plugin js are being deprecated

https://jquery.com/upgrade-guide/3.0/#deprecated-bind-and-delegate

Add build tools

See woocommerce/storefront-blog-customiser#25

WordPress 5.6 + PHP 8 Compatibility

WordPress 5.6 is currently scheduled for release on December 8, 2020 - and one of its goals is supporting the newest version of PHP (8)

See main Woo Core issue for PHP8 support in Woo Core: woocommerce/woocommerce#27674

Some of the changes in WP 5.6 (apart from PHP8 support) include:

Navigation menus block and screen in Core.
Automatic updates for major WordPress Core releases (opt-in).
New features from the block editor upgrades.
** Widgets-editing and Customizer support in Core.**
New Default theme, including an FSE compatible version.
Public beta of Full Site Editing.

All up I believe there are 7 gutenburg release being bundled - so based on issues like this I would recommend testing features that rely heavily on the customizer.

Suggest at a minimum

General smoke test of functionality (review docs for functionality and intended usage)
Check for PHP 8 warnings and errors during usage
Increase tested up to tags
Create follow-up issues for anything that needs to be fixed/investigated (or just fix it)

Reference for existing issues

Gutenberg phase 2, content built with blocks

[Enhancement]: As Blocks take the place of Widgets in Gutenberg phase 2, this footer bar plugin should utilize the same implementation to create content.

Footer Bar text color not saving....

WordPress 4.9.1
Storefront 2.2.5
Homestore 2.0.21
Footer Bar 1.0.3

When using Storefront Footer Bar, the following bug appears:

Customizer > Footer Bar > Text color

Choose any color. It reflects correctly in the Customizer.

But after publishing and closing Customizer, you will notice is has reverted back to the whitish default color.

Use 'trunk' instead of 'master' branch

Describe the bug

Automattic is standardizing on trunk for the primary(?) branch in repos, to avoid the unfortunate connotations of the term master (see twitter threads for more background: mislav; Una Kravets).

The plan is to align Woo and other A8C products to use the name trunk (core, extension etc.). This will also align with the direction the WordPress project is taking.

Logging an issue for changing this in this repo for visibility of when and how the change happens.

We'll need to update branch protection.

We'll likely use a process similar to:

Add a new trunk branch on a local clone.
Push trunk to GitHub repo.
Update default branch settings (if needed)
Update branch protection settings (if any)

At this point, the change is made. Anyone working on the repo should now use trunk.

Update any docs to reflect the change as well.

WooCommerce shortcodes do not display properly...

I tried using this WooCommerce shortcode in the Storefront Footer Bar.
[products visibility="featured" limit="5" columns="5"]

It blows up the size of the images to full-width, and they're all listed vertically, not horizontally. I.e. there are no "columns."

The same shortcode works well in a page.

displaying the footer bar conditionally (on sopme pages only)

Hi there,

First, thank you for providing this plugin. This is not really an issue but more of a feature request: How would I go about hiding the footer bar on the cart and checkout pages?

Thanks and keep up the good work! :)

Add README.md to make theme information more accessible

Is your feature request related to a problem? Please describe.

Not particularly related to a problem.

Describe the solution you'd like

Showing the theme information in a README.md makes them more readable.

Describe alternatives you've considered

n/a

Additional context

n/a

Pages reloading when footer bar background image not defined

Migrating a site from Canvas to Storefront I downloaded the Storefront Extensions Bundle and started using the footer bar.
After a while I noticed that every page request was being repeated. I eventually tracked it down to this plugin, determining that the problem occurred when no background image was defined for the footer bar.

Fix

The logic should be changed to not create the background-image property for .sfb-footer-bar when $footer_bar_bg_image is not set.

Workaround

Set a background image.