wooorm / iso-3166 Goto Github PK

For some reason I have yet to figure out, the English names for South African provinces aren't being consistently retrieved:

For reference it should be:

  {
    code: 'ZA-EC',
    name: 'Eastern Cape',
    parent: 'ZA'
  },
  {
    code: 'ZA-FS',
    name: 'Free State',
    parent: 'ZA'
  },
  {
    code: 'ZA-GP',
    name: 'Gauteng',
    parent: 'ZA'
  },
  {
    code: 'ZA-KZN',
    name: 'Kwazulu-Natal',
    parent: 'ZA'
  },
  {
    code: 'ZA-LP',
    name: 'Limpopo',
    parent: 'ZA'
  },
  {
    code: 'ZA-MP',
    name: 'Mpumalanga',
    parent: 'ZA'
  },
  {
    code: 'ZA-NC',
    name: 'Northern Cape',
    parent: 'ZA'
  },
  {
    code: 'ZA-NW',
    name: 'North-West',
    parent: 'ZA'
  },
  {
    code: 'ZA-WC',
    name: 'Western Cape',
    parent: 'ZA'
  },

Hi,

Hi,

I stumbled upon some names in the 2.js file that I'm not sure if they're 100% correct.
Code 'ES-A' has 'AlicanteAlacant' as a name. That is in fact Alicante (name of the region in Spanish) and Alacant (name of the region in Catalan) joined in a single word. Same happens in 'ES-CS' - 'CastellónCastelló' (Castellón in Spanish and Castelló in Catalan), 'ES-NA' - 'Navarra, Comunidad Foral deNafarroako Foru Komunitatea' (Navarra, Comunidad Foral de in Spanish, Nafarroako Foru Komunitatea in Basque) and 'ES-PV' - 'País VascoEuskal Herria' (País Vasco in Spanish, Euskal Herria in Basque).

While the data is correct for those cases, as both names are official, the representation of the data, joining both without anything that indicates so, seems misleading. I think they'd be better with the local variant indicator, as 'LR-RI', 'MU-CC' and some others.

I'd be happy to do the PR myself but wanted to open the issue first to check that I'm not wrong about that.

Thank you

I am looking at the library and caught a possible issue. In Spain some subdivisions have the name in 2 languages. However, the string of the name concatenates the two versions.

Example:

{ code: 'ES-NA', name: 'NavarraNafarroa', parent: true },

This is Navarra in Spanish, and Nafarroa in Basque. But the name is not usable in this way.

Either the object should contain the two languages, or allow a better split. In theory, the iso table contains the language code which would make this much easier.

Shall we consider to refactor the list including the language code?

The ISO codes and the mapping is collected from ISO.org???
Data is as per standards but still there are some extra information that user may need to implement some business logic.
Can someone please confirm?