GithubHelp home page GithubHelp logo

Comments (7)

Adam-Collier avatar Adam-Collier commented on May 18, 2024 1

Thanks for sending over the example, it made sense after looking at it that react-live isn't needed when it handles so much of it itself. I've managed to get something working with async here: https://github.com/Adam-Collier/vite-mdx-playground/tree/evaluate_async however there are a couple of problems I'm coming across when it comes to handling errors. For example if I was to do something like <Row>some content here</Row> (where Row isn't imported) the error bounces back to the Error Boundary rather than being handled in the try catch and gets logged to the console as an uncaught error. But if I remove the try catch and just start writing an opening tag < the error isn't caught by the ErrorBoundary and goes straight to console (I think this is promise related and the Error Boundary doesn't handle those cases). So I'm wondering if there is a way of handling the errors that I may be missing here? so they are caught and shown in the UI rather than logging to the console

from xdm.

wooorm avatar wooorm commented on May 18, 2024
  • Why do you want an MDX live editor?
  • Why use compileSync, and not compile? This could probably be async
  • Why use compile at all, and not evaluate?
  • evaluate supports exports, and can support imports too
  • evaluate gives you a React node back — that’s what you’re looking for, right?

from xdm.

Adam-Collier avatar Adam-Collier commented on May 18, 2024

It's potentially going to live within a CMS so we can preview the content and save it. I tried compile rather than compileSync to begin with but LiveProvider's transformCode just seems to ignore async functions. Ahh evaluate seems more like it! So now I have:

import React, { useState } from 'react';
import * as runtime from 'react/jsx-runtime.js';
import { LiveProvider, LiveEditor, LiveError, LivePreview } from 'react-live';
import { evaluateSync } from 'xdm';

import './App.css';

function App(props) {
  const [code, setCode] = useState('# Hello, world!\n\n This is some markup!');

  return (
    <div className="App">
      <LiveProvider
        code={code}
        transformCode={(code) => {
          let { default: Content } = evaluateSync(code, {
            ...runtime,
          });
          console.log(Content);
          return String(Content);
        }}
        scope={{}}
      >
        <LiveEditor />
        <LiveError />
        <LivePreview />
      </LiveProvider>
    </div>
  );
}

export default App;

but now _jsxs is not defined so I'm assuming something needs to be added in scope?

from xdm.

wooorm avatar wooorm commented on May 18, 2024

OK, getting closer.

The next thing: the package react-live is doing work that xdm is already doing.
You don’t need it at all (it’s already done).
(And in fact serializing String(Content) doesn‘t work)

The readme of react-live explains what it’s doing and using under the hood. That might help to point you in the right direction.

from xdm.

wooorm avatar wooorm commented on May 18, 2024

Here’s a tiny, bad, example, of how it can be done: https://codesandbox.io/s/romantic-shannon-k1goq?file=/src/App.js.

You could use compileSync, if you really want to use react-live, it might work, but they duplicate several things: Bublé is packed at 130kb — the size of the whole of xdm.

from xdm.

wooorm avatar wooorm commented on May 18, 2024

A bit of googling shows me: https://medium.com/trabe/catching-asynchronous-errors-in-react-using-error-boundaries-5e8a5fd7b971.

from xdm.

wooorm avatar wooorm commented on May 18, 2024

Closing this for now. I think it has garnered enough conversation to be useful for future readers. Feel free to comment with more Qs tho!

from xdm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.