workbooks / client_lib Goto Github PK

I want to integrate this issues tracker with Workbooks. Let's use Zapier!

Any reason you guys opted not to release the Ruby wrapper as a gem?

The name "workbooks" seems to be available 😄

Would it be possible to provide this library in python? Please I need it quick

The documentation for the Ruby Log() method states that there are four params but then only lists three. It is missing the log_size method. ( the param is log_size_limit )

I've noticed this client_lib repo hasn't been updated in over a year and a half. That would be all good/fine except that concerns me Workbook hasn't added any features, since the client_lib's haven't been updated and there are a couple of issues filed, for instance #6 hasn't been answered since its creation over 6 months ago.

If someone could address my concerns and possibly make a CONTRIBUTING guide?

Feature request, use http://getcomposer.org to manage package.

From the console tracelistener:
URl to connect: «https://secure.workbooks.com/accounting/invoices.api?_dc=389000?_limit[]=1&_select_columns[]=lock_version&_ff[]=id&_ft[]=eq&_fc[]=43851&api_key= (etc)

Surely that should be a "&" not a "?" before _limit[]
Same for most queries - the first real query parameter is therefore ignored!

Update: sample VB code:

Dim workbooks As WorkbooksApi.WorkbooksApi = LoginToWorkbooks(apikey)
Dim queryParams As New Dictionary(Of String, Object)
Dim response As WorkbooksApi.WorkbooksApiResponse
Dim endPoint As String

endPoint = "accounting/invoices"
queryParams.Add("_limit", 1)
queryParams.Add("_select_columns[]", "lock_version")
queryParams.Add("_ff[]", "id")
queryParams.Add("_ft[]", "eq")
queryParams.Add("_fc[]", 43851)
response = workbooks.assertGet(endPoint, queryParams, Nothing)

which gives this console output

ApiWrapper Information: 2 : URl to connect: «https://secure.workbooks.com/accounting/invoices.api?_dc=283000?_limit=1&_select_columns[]=lock_version&_ff[]=id&_ft[]=eq&_fc[]=43851&api_key=REMOV£D&client=api, »

This method:

public int? getTotal() {
if (response != null) {
Dictionary<string, object> responseData = (Dictionary<string, object>) response["response"];
total = (int?)responseData["total"];
}
return total;
}

throws an exception because the cast is invalid.

Suggested fix:

public int? getTotal() {
if (response != null) {
Dictionary<string, object> responseData = (Dictionary<string, object>) response["response"];
var t = (JsonElement)responseData["total"];
if (t.ValueKind == JsonValueKind.Number) return t.GetInt32();
}
return null;
}

System.Web.Script.Serialization is part of System.Web.Extensions which is .NET Framework only.

For .NET Core compatibility this should be replaced with System.Text.Json.Serialization