workday / mps-code-reviewer Goto Github PK

The paths of the zip files are wrong in the gradle file, which results in a build failure when running the install task.

A follow-up from #15 - we should have support for v2.0 of the API. This may be implemented as a separate connection depending on the differences between the versions.

Add safeguards to the build.gradle script to enforce the use of java 11 instead of failing later with cryptic error messages.

It would be nice to have an action in the preference page to test if the connection can be established

The plugins should be installable from the gradle script to make it easier for users to consume the plugins or get startet.

The reviewer should provide an extension mechanic to allow declaring new backends.

It seems that the gitChangeListener in the RefreshAction can be installed to late. This leads to the fact that it is not called and thus the currentGitBranch is null until I change the branch explicitly

One of the main goals of this project is to support multiple review backends with the basic functionality of commenting & approval. A next step would be to implement GitHub.

This would entail implementing at least the following:

• GitHubConnection (how to interface with the API)
• Preferences (configure the connection)

A user should be able to approve, decline/reopen, or request additional work on a review using the plugin.

This should be exposed as a trio (+/-) of buttons in the top-right-hand corner of the Active Review View (on the same line as the branch status).

When clicking one of the options, a popup should show giving the user a chance to enter an approval message.

Some hosts may not allow certain actions, this should be configurable via a new method on ReviewHostDefinition.

Discussion:
Should decline/reopen be exposed on the top-level UI, or should it be hidden inside a "additional options" dropdown? Bitbucket takes this approach - declining affects the overall state of the PR, not just what states it can transition to.

I had to ask @szabta89 in order to understand what to fill in the preference page. It would be nice if I could just copy the the repository URL and the page would figure out on its own

Bitbucket cloud does not support personal access tokens. Instead one has to create either an app password or an oAuth key. The plugin should be able to deal with either of those.

See https://developer.atlassian.com/cloud/bitbucket/authentication-for-apps/