worldbank-transport / driver Goto Github PK

Probably only an issue in development environment, but maybe worth looking into.

There is a Geography resource in ase-scripts and a Boundaries resource in scripts that both perform queries against /api/boundaries/. We should consolidate these to reduce duplication and potential confusion.

The production deploy won't be on AWS, but it would be great to have a basic AWS setup in place that will allow us to easily test the current develop branch.

In some places, particularly the "add" accident view, we're hiding buttons instead of disabling them. We really should set them to be disabled instead of just removing them from the UI (this causes weird styling, and also isn't a best practice).

Is currently...

Should be...

Record list opens to page 2 of pulled in records

Console error that UUID not found.

See #103.

Minify and possibly concatenate partial templates, and possibly cache them with ngtempates grunt task.

Given read-only permissions, and limit access to tables needed by Windshaft (probably doesn't need access to user info).

If a schema field is added after deleting a field, the fresh field's form will not be blank; it will instead be populated with data from the schema field that was deleted.

Pagination was added to the record list, so we'll need to style that. Also style view & edit buttons.

00 through 23 for hours is probably more universal and fits better. Style hover effect popovers. Give the squares a nicer color and light gray when no incidents are reported.

In the list view (including the list in the tabbed details interface), non-text items, such as images and relationships, are being rendered as text. They should be rendered based on their type, so the image can be shown, some relationship details can be extracted, etc. Also, paragraph fields should be truncated at a certain number of characters.

The details object is currently added to the object with the convention <title> Details, and that convention is used in a couple places. It'd be better to have an explicit flag (or something of the sort) to make it less brittle (e.g. so it doesn't break if someone changes the title).

Need tests for controller and directive.

The Leaflet map tiles do not always line up.

The schema editor UI only shows the first ten items, without pagination, so there's no way to access the rest.

Filter bar now displays on both the map page and list view, so we'll need to remove the original filters from the table. We'll also need to restyle the filters, including adjusting some input styling.

• Fit map to page (do not scroll vertically)
• Remove bar of white space below header
• Set z-index of header and header dropdowns to show over map controls
• Fix layer switcher styling (grey background)

Attempting to save a record on vagrant-hosted port 7000 returns 403 with error:

CSRF Failed: CSRF token missing or incorrect.

Saving records works when hosting via grunt on port 7002.

Many of the tests show extraneous requests being made. Because this happens in a central place there's some logic in place for deciding whether a request needs to be made or whether the promise for an already underway request needs to be handed out - it would be good to investigate this and reduce requests.

Since we're not using the modal view anymore, let's take that styling since it looks nicer and apply it to these pages. The add page needs some love, too.

Alternatively, default it to occurred_from with a checkbox, but allow overriding.
See: #87 (comment)

If the GeographyState is changed to select a new geometry, the Boundary dropdown will go blank, implying that no Boundary is selected, but calls to BoundaryState.getSelected() will still return the previously selected Boundary, if there was one.

There is a bug in the timeout logic for notifications that causes old notifications to be displayed after they have already been dismissed. Can be replicated by saving a schema, switching the view, then switching back to the edit schema view.

Get the app running to make sure there will be no major issues with the docker setup/etc. This deploy process should be documented so we can provide instructions to DOST and ask them to attempt to bring up a new VM and get it working.

Looks like this button was accidentally removed in #158.
I added it back temporarily in #186, to re-enable the ability to add records, but it'll need to be shifted around/styled.

If content is taller than the screen, browser should scroll vertically; instead, content is cut off at bottom of screen.

Modifying the web app config.js template has no effect without making a matching edit to the schema editor config.js. On provisioning, the web app config.js template file does get copied to the correct directory (/opt/web/) and is correct in the web docker container.

Apparently both config.jsfiles load on a request to the web app, the editor config loading second.

Map popups no longer display, due to the SELECT clause of the passed query not casting its fields to strings. One solution might be to just return the WHERE clause from the Django query endpoint instead of the full query, and define the fields in Windshaft.

Also, we should consider removing the slug and label from the record model as they seem unneeded for records.
See notes and TODOs in record/add-controller.js

See: #87 (diff)

See TODO in schema/edit-controller.js

The Windshaft config currently accepts an argument for the record type UUID. It's not yet wired up to respond to the record type dropdown.

We had a card previously which was just to zoom to the boundary. We still need that, but now will also be applying an application-wide filter using those bounds. It will affect the dashboard, map, and records list pages.

User stories:
"As a manager in Metro Manila, I usually want to see graphs and maps related to my jurisdiction so that I know what's going on there."
"As a manager in Metro Manila, I may want to see graphs and maps related to other jurisdictions so that I know what's going on there."
"As a manager in Metro Manila, I may want to see graphs and maps related to the national jurisdiction so that I know what's going on everywhere."

Once a record type is selected, there's no way to unselect it to show all types again.

Add a new interface for saved filters in topic/prototypes, post screenshot

After provisioning, the editor app is running, but the web app does not run without executing the grunt.sh script from the host to serve it.

The initial app load takes ~11.5s, running locally, before the schema populates and the filter bar and records can show up. The /api/boundarypolygons/ fetch seems to taking up most of that time.

See: #67 (comment)

On retina screens, tile labels are unreadably small.

http://leafletjs.com/reference.html#tilelayer-detectretina

Despite the 3857 CRS set for the map, Leaflet markers are set and return coordinates in 4326.

Storing data in 4326 probably makes more sense than reprojecting client side to set markers.

after vagrant up with existing VMs.

Some modules need to be used by both the schema_editor and web applications (e.g. json-editor directive, and probably some other utilities and resources). These should be moved to separate repos and packaged with bower.

Until this is implemented, symlinks will be used to share this functionality.