Error in multiple ViewModels with PropertyChanged.Fody about nodenetwork

[ccgould]

This causes a problem with refreshing the nodes tho

[Wouterdek]

It seems you have copied and modified the example code. I can't really investigate this without a reproducible example. Could you upload your code?

[ccgould]

I tried it in the demo project as well if you install the new propertychanged.fody it crashes

[ccgould]

[ccgould]

[Wouterdek]

Here is what happens:
After compilation, fody inserts a call to RaisePropertyChanged in any property of a class that implements the INotifyPropertyChanged interface (directly or indirectly).

Before fody:

public PortType PortType
{
    get => _portType;
    set => this.RaiseAndSetIfChanged(ref _portType, value);
}
private PortType _portType;

After fody:

public PortType PortType
{
  get
  {
    return this._portType;
  }
  set
  {
    if (this._portType == value)
      return;
    IReactiveObjectExtensions.RaiseAndSetIfChanged<CodeGenPortViewModel, PortType>((M0) this, (M1&) ref this._portType, (M1) value, nameof (PortType));
    this.ReactiveUI.IReactiveObject.RaisePropertyChanged(<>PropertyChangedEventArgs.PortType);
  }
}

As you can see, this does not make sense. It seems this is not a NodeNetwork issue, but rather that PropertyChanged.Fody is not really compatible with ReactiveUI.

Is there any reason why you are not using ReactiveUI.Fody instead? It is specifically tailored for ReactiveUI, is supported by the ReactiveUI team, and seems to work perfectly here.

[ccgould]

Yea it is a Fody and ReactiveUI issue. When I used ReactiveUI.Fody I lost my property changed functionality did yours work or is there an extra step I am not familiar with ReactiveUI that much

[Wouterdek]

It worked fine for me after following the guide on the github page: https://github.com/kswoll/ReactiveUI.Fody/blob/rxui7beta/Readme.md

I am closing this issue because it is not related to NodeNetwork, but rather to Fody/ReactiveUI

[ccgould]

Ok ill give it a try