Comments (4)
I think the best way to do this is to actually make the followers the base concrete class instead of the WPI_* ones.
from frc-characterization.
Turning off motor safety is actually what we want in this situation (unless we want to call feed
on the followers), and explicitly disabling it is a lot clearer than implicitly turning it off via the base non-WPI classes, IMO.
from frc-characterization.
I suppose for the drivetrain characterisation that would make sense. But for simple-motor for example we don't need them to implement SpeedController.
from frc-characterization.
That’s a good point. I used the WPI classes when I wrote simple motor in order to be consistent with the other projects (you have to enter in WPI_TalonSRX in the other projects’ configs after all), but we could switch to the base class everywhere (not using DifferentialDrive could be good because of the whole motor inversion misfeature anyway.)
Ultimately I err on the side of lazy, so I would prefer disabling motor safety (and if there are no other serious objections then I’ll go ahead and PR that in the next couple of days.)
from frc-characterization.
Related Issues (20)
- [CRASH] IsADirectoryError: logger_analyzer/templates HOT 2
- Program abort on start (macOS 11.1) HOT 3
- What are kG and kCos? HOT 5
- Generated project doesn't include .vscode or .wpilib directories
- Crash when attempting to analyze data HOT 3
- Replace ast.literal_eval() with json.load()
- Track-width computation doesn't account for wheel circumference HOT 6
- TalonFX encoder inversion not working HOT 2
- Add gyro rotations to logger display when doing track width characterization
- Can't generate Simple-Motor SparkMax project HOT 10
- EPR example is wrong for CTRE Mag Encoder
- List index out of bounds HOT 1
- Unnecessary division by 4 on the Encoder EPR
- Failed to generate project, "Exception in Tkinter callback" HOT 4
- Tool does not generate project HOT 7
- Unable to generate project HOT 8
- Drive Train Characterization Tests Timing Out & Not Recording Data HOT 2
- Integer division truncates down to 0 HOT 1
- LLVM: Out of memory HOT 4
- IndexError upon trying to analyze data HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frc-characterization.