GithubHelp home page GithubHelp logo

Comments (4)

auscompgeek avatar auscompgeek commented on July 28, 2024 1

I think the best way to do this is to actually make the followers the base concrete class instead of the WPI_* ones.

from frc-characterization.

pietroglyph avatar pietroglyph commented on July 28, 2024

Turning off motor safety is actually what we want in this situation (unless we want to call feed on the followers), and explicitly disabling it is a lot clearer than implicitly turning it off via the base non-WPI classes, IMO.

from frc-characterization.

auscompgeek avatar auscompgeek commented on July 28, 2024

I suppose for the drivetrain characterisation that would make sense. But for simple-motor for example we don't need them to implement SpeedController.

from frc-characterization.

pietroglyph avatar pietroglyph commented on July 28, 2024

That’s a good point. I used the WPI classes when I wrote simple motor in order to be consistent with the other projects (you have to enter in WPI_TalonSRX in the other projects’ configs after all), but we could switch to the base class everywhere (not using DifferentialDrive could be good because of the whole motor inversion misfeature anyway.)

Ultimately I err on the side of lazy, so I would prefer disabling motor safety (and if there are no other serious objections then I’ll go ahead and PR that in the next couple of days.)

from frc-characterization.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.