[Implement sniff] Have either UNIX or DOS line endings for PHP, JS and CSS files about wpthemereview

[grappler]

It may be a WARNING in the theme check but the check fails so it should be REQUIRED.

We want to reduce the number of manual requirements with automated. Once it is automated it the theme sniffs should suffice as documention.

[jrfnl]

Once it is automated it the theme sniffs should suffice as documention.

I'm not sure I agree with that.

Especially new theme authors - but probably also existing ones - will probably be more comfortable with reading a list of requirements and recommendations.
Having a list with the rules in the handbook makes it so people are not surprised by (new) rules once they get into the review process.
This is similar to how WPCS handles this. The handbook is leading and only rules which are explicit in the handbook get added to the sniff rulesets.

[grappler]

Green light to go ahead :
https://make.wordpress.org/themes/2016/07/12/meeting-notes-for-2016-july-12/

Will look for a good way to document the sniffs. Will raise the question at the next team meeting? Perhaps we could track them in a wiki till it is complete.

[grappler]

The PR has been merged.

[grappler]

Sorry, still need to update the documentation

[grappler]

I know the PR has been merged but I think we need to revert this. There is no need for us to require themes to only use of type of line endings.

PHPCS has an internal Warning Internal.LineEndings.Mixed that we can use to make sure the files only have one type of line endings.

The code looks simple enough

        // Check for mixed line endings as these can cause tokenizer errors and we
        // should let the user know that the results they get may be incorrect.
        // This is done by removing all backslashes, removing the newline char we
        // detected, then converting newlines chars into text. If any backslashes
        // are left at the end, we have additional newline chars in use.
        $contents = str_replace('\\', '', $contents);
        $contents = str_replace($this->eolChar, '', $contents);
        $contents = str_replace("\n", '\n', $contents);
        $contents = str_replace("\r", '\r', $contents);
        if (strpos($contents, '\\') !== false) {
            $error = 'File has mixed line endings; this may cause incorrect results';
            $this->addWarning($error, 0, 'Internal.LineEndings.Mixed');
        }