GithubHelp home page GithubHelp logo

Comments (4)

grappler avatar grappler commented on July 2, 2024

I think this will be a difficult check to run. Even with Pig Latin you need to do a manual check for which strings are not being converted.

These are the three main forms that I could think of that we would need to catch.

<span>Hello World</span>
echo 'Hello World!'
array (
    'title' => 'Hello World!',
)

We could help the manuall check by listing strings that need to be check. This would change the check from an ERROR to a WARNING.

Let's keep this as low priorty at the moment.

from wpthemereview.

dingo-d avatar dingo-d commented on July 2, 2024

Do we want to work on this, or can we close this issue?

from wpthemereview.

jrfnl avatar jrfnl commented on July 2, 2024

The "check that all translatable strings are in the same language" bit may be sniffable if we could do some sort of dictionary check, possibly using the PHP ICU extension, but the "check that all text strings are translatable" bit is neigh impossible to sniff for.

from wpthemereview.

jrfnl avatar jrfnl commented on July 2, 2024

All the same, if at all, this should probably be addressed in WPCS itself. Not sure if an upstream issue exists for this yet.

from wpthemereview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.