Check Customizer sanitize-callback is not empty about wpthemereview

[khacoder]

I have a sniff for this Issue

[justintadlock]

There's an issue with the current check for this related to custom setting classes. Often, custom setting classes have their own sanitize() method. The $wp_customize->add_setting() call has no need for sanitize_callback to be set in this particular case.

Example:

$wp_customize->add_setting(
    new JT_Customize_Setting_Class( $wp_customize, $name, $args )
);

This one has bugged me for a while. We may as well try to address it in the new system.

[khacoder]

Shouldn't the new class be under $wp_customize->add_control() ?

[justintadlock]

Shouldn't the new class be under $wp_customize->add_control() ?

A control class, yes. A setting class, no.

[justintadlock]

For example, here's a setting class that might not necessarily need for a developer to use sanitize_callback: https://github.com/justintadlock/hybrid-core/blob/3.0/customize/setting-array-map.php Assuming the developer wants to go with the default of sanitize_text_field, there's no need to set the argument.

And, in some cases, setting sanitize_callback won't even work when the custom setting class overwrites this with a sanitize() method.