No php file functions about wpthemereview

[dd32]

Just throwing a note out there - WP_Filesystem shouldn't be used in the way we see it used in themes due to these rules. It's not a replacement for file_get_contents() and the like, and is only really supposed to be used when FTP/file-editing is needed interactively.

This TRT rule makes themes effectively hide what they're doing, when it's a completely legitimate use-case for the direct filesystem calls.

[justintadlock]

^ One of the reasons I've been pushing to get file_get_contents() OK'd.

[khacoder]

I have this sniff ready to go and will upload after final testing.

[grappler]

If the check is failing which it was in the Theme Check it should have been Required instead of a Warning so an Error is OK.

[jrfnl]

@dd32 As these things are in WPCS as well, I'd love to hear your voice in the discussion being had here: WordPress/WordPress-Coding-Standards#1265.

(Merged) PR WordPress/WordPress-Coding-Standards#1374 in response to WordPress/WordPress-Coding-Standards#943 is hopefully a step in the right direction ?

[dingo-d]

What is the status of this issue?