wtag / dragonfly-google_data_store Goto Github PK

Hi @luxflux,

Thanks for all of your work on this. I am wondering if you and/or wtag are still maintaining this gem. I used this as the base of our dragonfly/GCS integration, and wanted to make that work more reusable. I'm happy do PRs into here if you'd like, or I can go ahead and make a separate gem. The main changes I needed to make were:

• Addressing missing filename/extension (similar to #2)
• Allowing for use of credentials instead of keyfile so you can pass in a hash, as allowed by updates to the google storage gem
• Adding some tests

The uploaded assets should be saved with the correct filename. Generate the file_uid with the filename at the end (as the S3 datastore does). Makes it easier to move from S3 to Google Cloud Storage.

uploaded filename: filename.jpg
---
current:   2017/05/12/16/09/69e128fb-6868-40ff-9351-c5248cd9cbf7
preferred: 2017/05/12/16/09/69e128fb-6868-40ff-9351-c5248cd9cbf7/filename.jpg

Thanks for creating this gem for us!

Edit:

Created a pullrequest with working fix #2 please release a new version of that gem (1.0.1)