GithubHelp home page GithubHelp logo

Comments (1)

Cocola avatar Cocola commented on June 7, 2024

Hi WTTJ team,
I was looking at welcome-ui, digging at some components and found this issue too.
I made a branch that fix the problem but it require a CSS declaration on a higher level (Field) than in TimePicker itself.
It's probably due to how react-datepicker is handling the DOM, by wrapping components with html and apeending the aria-live message with class react-datepicker__aria-live.
It seems that i don't have the permission to push a fix branch, i worked on: packages/Field/src/styles.ts

from L20. It works but maybe not the best solution to handle CSS generated by the package react-datepicker.

export const Field = styled('div').withConfig({ shouldForwardProp })<StyledFieldProps>(
  ({ checked, isCheckable, isRadioGroup, withHintText }) => css`
    .react-datepicker__aria-live {
      position: absolute;
      clip-path: circle(0);
      border: 0;
      height: 1px;
      margin: -1px;
      overflow: hidden;
      padding: 0;
      width: 1px;
      white-space: nowrap;
    }
    ${isCheckable &&
    css`
      input {
        margin-top: xs;
      }
    `}
    ${StyledLabel} {
      ${isCheckable && checkableFieldStyles};
      ${isCheckable && withHintText && th('defaultFields.checkablelabel.default')}
      ${checked && th('defaultFields.checkablelabel.checked')}
      ${!isCheckable &&
      css`
        margin-bottom: sm;
      `}
      ${isRadioGroup &&
      css`
        margin-bottom: md;
      `}
    }
    ${system};
  `
)

from welcome-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.