Comments (1)
Hi WTTJ team,
I was looking at welcome-ui, digging at some components and found this issue too.
I made a branch that fix the problem but it require a CSS declaration on a higher level (Field) than in TimePicker
itself.
It's probably due to how react-datepicker is handling the DOM, by wrapping components with html and apeending the aria-live message with class react-datepicker__aria-live
.
It seems that i don't have the permission to push a fix branch, i worked on: packages/Field/src/styles.ts
from L20. It works but maybe not the best solution to handle CSS generated by the package react-datepicker.
export const Field = styled('div').withConfig({ shouldForwardProp })<StyledFieldProps>(
({ checked, isCheckable, isRadioGroup, withHintText }) => css`
.react-datepicker__aria-live {
position: absolute;
clip-path: circle(0);
border: 0;
height: 1px;
margin: -1px;
overflow: hidden;
padding: 0;
width: 1px;
white-space: nowrap;
}
${isCheckable &&
css`
input {
margin-top: xs;
}
`}
${StyledLabel} {
${isCheckable && checkableFieldStyles};
${isCheckable && withHintText && th('defaultFields.checkablelabel.default')}
${checked && th('defaultFields.checkablelabel.checked')}
${!isCheckable &&
css`
margin-bottom: sm;
`}
${isRadioGroup &&
css`
margin-bottom: md;
`}
}
${system};
`
)
from welcome-ui.
Related Issues (20)
- useModalState onClose triggered on mount
- Icon is still in black when I change type of button
- Text properties on Forms
- Popover : triggerMethod hover HOT 1
- DropdownMenu: always hide on click HOT 6
- Tag - remove role listitem on component
- [Infra] Remove Netlify deployment HOT 1
- Date picker
- Label with count
- Drawer not responsive on mobile
- Figma : Select with a long hint
- [DatePicker] The forwarded ref isn't forwarded
- Visual Testing
- Misaligned radio on RadioGroup
- [Modal] modal types doesn't use ariakit dialog types HOT 1
- Update Twitter/X icon HOT 2
- Missing (peer)Dependencies HOT 2
- Issue with the icon "thumbs" HOT 2
- [Modal] isn't visible when we update the state during the opening
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from welcome-ui.