wuild / gatherlite Goto Github PK
View Code? Open in Web Editor NEWWorld of Warcraft: Classic Gathering addon keeping track on where you have found stuff
License: MIT License
World of Warcraft: Classic Gathering addon keeping track on where you have found stuff
License: MIT License
Describe the bug
When hovering a node collected from older version of the addon, LUA error is produced and it doesn't display what player collected it. The error seems to appear on every single node collected from around version 1.1.5. Do note that it doesn't appear on herbs collected on version 1.1.7.
The following error will appear:
Message: Interface\AddOns\GatherLite\methods.lua:497: attempt to index field 'player' (a nil value)
Time: Fri Sep 6 13:39:32 2019
Count: 143
Stack: Interface\AddOns\GatherLite\methods.lua:497: attempt to index field 'player' (a nil value)
Interface\AddOns\GatherLite\methods.lua:497: in function <Interface\AddOns\GatherLite\methods.lua:484>
Locals: (*temporary) = nil
(*temporary) =
To Reproduce
Steps to reproduce the behavior:
I was in a party with the party share turned on, I see the debug message leave my character when i pick up a fish however nothing is received by my other party members.
I have checked that we are on the latest version and that we both have party share enabled. Have used SpyDon which monitors the chat channel to see the GatherLite message leave but doesn't seemed to be received at destination?
I was in Orgrimmar and he was just outside in Durotar.
Nodes are not being localized to Zone map.
the tooltip when hovering over nodes on map or minimap dosen't work correctly. it shows the node name within the tooltipframe, but the rest from last visited onward is not in the frame bur just plain text nearby the frame. it also shows lua error :
`1x GatherLite\methods.lua:459: attempt to index local 'classColor' (a nil value)
GatherLite\methods.lua:459: in function <GatherLite\methods.lua:440>
Locals:
classColor = nil
(*temporary) = defined =[C]:-1
(*temporary) = GatherLiteTooltip {
0 =
updateTooltip = 0.200000
needsReset = true
BottomOverlay = {
}
TopOverlay = {
}
}
(*temporary) = "Found by:"
(*temporary) = "|cffffffff30/08/2019 - 07:34:29|r"
(*temporary) =
(*temporary) = "/"
(*temporary) = "08"
(*temporary) = "/"
(*temporary) = "2019"
(*temporary) = " - "
(*temporary) = "07"
(*temporary) = ":"
(*temporary) = "34"
(*temporary) = ":"
(*temporary) = "29"
(*temporary) = "|r"
(*temporary) = "attempt to index local 'classColor' (a nil value)"
f = miningworldmap29 {
0 =
texture = {
}
}
GatherLite =
Gatherlite no longer shows me descriptions on maps. I see the markers on the map but when I mouseover i no longer get a description (loot), it just highlight the icon and no description.
I also noticed that sometimes I see my markers on my minimap and then they vanish,comeback...
The addon is up to date btw (from twitch app).
Message: Interface\AddOns\GatherLite\methods.lua:536: HereBeDragons-Pins-2.0: AddMinimapIconWorld: 'instanceID', 'x' and 'y' must be numbers
Time: Mon Sep 2 15:04:35 2019
Count: 1448
Stack: Interface\AddOns\GatherLite\methods.lua:536: HereBeDragons-Pins-2.0: AddMinimapIconWorld: 'instanceID', 'x' and 'y' must be numbers
[C]: in function error' ...erLite\Libs\HereBeDragons\HereBeDragons-Pins-2.0.lua:540: in function
AddMinimapIconWorld'
Interface\AddOns\GatherLite\methods.lua:536: in function createMinimapNode' Interface\AddOns\GatherLite\methods.lua:398: in function
drawMinimap'
Interface\AddOns\GatherLite\events.lua:18: in function <Interface\AddOns\GatherLite\events.lua:14>
Locals: (*temporary) = "HereBeDragons-Pins-2.0: AddMinimapIconWorld: 'instanceID', 'x' and 'y' must be numbers"
Lot of quest items are displayed on the map as a treasure cause these are items which you need to open on the ground like a chest.
Maybe add option "Hide/Show Quest-Items" on Minimap to disable them, or never track opening this things. Thanks a lot!
IS there a way to hide the minimap icon? Not the NODES themselves.
Also, alternatively have the minimap button LDB support for bazooka/titanpanel?
CHEERS!
Hi again ;)
like the title says fishspot tracking just tracks every fishing, not only fishing spots. UC has no spots and it still shows spots when i skilled fishing there
Its cool that you sync your node database with newely found nodes, but it could also help to periodically send out "old" found nodes you don't farm anylonger to your party/guild in order to build a larger database.
Never Problems since i use GatherLITE.
Last Night my first run on HdW and my FPS are dropping from over 200 to under 30 step by step. No new Addons installed, the newest update is installed... re-install from the Addons folder to.. but i have now unstoppable LUA-Errors from GatherLITE. I cant use it anymore.
I deactivated all my Addons, only GatherLITE is active... no results. Only GatherLITE give me LUA-Errors.
Message: ...erLite\Libs\HereBeDragons\HereBeDragons-Pins-2.0.lua:714: HereBeDragons-Pins-2.0: AddWorldMapIconMap: 'uiMapID', 'x' and 'y' must be numbers Time: Tue Sep 3 11:44:17 2019 Count: 11423 Stack: ...erLite\Libs\HereBeDragons\HereBeDragons-Pins-2.0.lua:714: HereBeDragons-Pins-2.0: AddWorldMapIconMap: 'uiMapID', 'x' and 'y' must be numbers [C]: in function
error'
...erLite\Libs\HereBeDragons\HereBeDragons-Pins-2.0.lua:714: in function AddWorldMapIconMap' Interface\AddOns\GatherLite\methods.lua:518: in function
createWorldmapNode'
Interface\AddOns\GatherLite\methods.lua:362: in function `drawWorldmap'
Interface\AddOns\GatherLite\events.lua:19: in function <Interface\AddOns\GatherLite\events.lua:14>
Locals: (*temporary) = "HereBeDragons-Pins-2.0: AddWorldMapIconMap: 'uiMapID', 'x' and 'y' must be numbers"
`
Right now you are assuming that every loot item in a treasure chest is an item, and any coins in the chest cause an error. Specifically, GetLootSlotLink() returns nil if the item is money, and you aren't handling that case.
This is the error taken from my !BugGrabber addon, it's coming up thousands of times and causing me the performance warning in chat:
{ ["message"] = "Interface\\AddOns\\GatherLite\\events.lua:41: attempt to perform arithmetic on local 'elapsed' (a table value)", ["time"] = "2019/08/31 12:43:57", ["locals"] = "elapsed = <unnamed> {\n 0 = <userdata>\n DoHooks = <function> defined @Interface\\AddOns\\SniperTips\\lib.lua:166\n OnApplyConfig = <function> defined @Interface\\AddOns\\SniperTips\\lib.lua:179\n}\n(*temporary) = <table> {\n spellIDs = <table> {\n }\n drawWorldmap = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:286\n findSpell = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:63\n updateMiniMapPosition = <function> defined @Interface\\AddOns\\GatherLite\\settings.lua:280\n tablelength = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:20\n createWorldmapNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:443\n debug = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:13\n tooltip = GatherLiteTooltip {\n }\n RegisterCallback = <function> defined @Interface\\AddOns\\Masque\\Libs\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:90\n gatherSpellRanges = <table> {\n }\n nodes = <table> {\n }\n insertDatabaseNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:205\n hideTooltip = <function> defined @Interface\\AddOns\\GatherLite\\GatherLite.lua:64\n TimeSinceLastUpdate = 0\n UpdateInterval = 1\n ParseSentData = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:509\n needMapUpdate = true\n IsNodeInRange = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:97\n callbacks = <table> {\n }\n removeWorldmapNodes = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:505\n frames = <table> {\n }\n minimap = GatherLite_MinimapButton {\n }\n locale = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:43\n findSpellType = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:48\n checkNodePositions = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:490\n showTooltip = <function> defined @Interface\\AddOns\\GatherLite\\GatherLite.lua:50\n createMinimapNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:466\n print = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:8\n findExistingNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:106\n version = \"1.1.2-classic\"\n defaultConfigs = <table> {\n }\n showingTooltip = false\n updateDatabaseNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:258\n foundNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:128\n checkMinimapNodes = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:82\n isClassic = true\n classColours = <table> {\n }\n mainFrame = <unnamed> {\n }\n tracker = <table> {\n }\n createNodeTooltip = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:396\n WorldMapOpen = false\n minimapFrame = <unnamed> {\n }\n CopyDefaults = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:29\n UnregisterCallback = <function> defined @Interface\\AddOns\\Masque\\Libs\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:153\n drawMinimap = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:337\n name = \"GatherLite\"\n}\n(*temporary) = 0\n(*temporary) = \"attempt to perform arithmetic on local 'elapsed' (a table value)\"\nGatherLite = <table> {\n spellIDs = <table> {\n }\n drawWorldmap = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:286\n findSpell = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:63\n updateMiniMapPosition = <function> defined @Interface\\AddOns\\GatherLite\\settings.lua:280\n tablelength = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:20\n createWorldmapNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:443\n debug = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:13\n tooltip = GatherLiteTooltip {\n }\n RegisterCallback = <function> defined @Interface\\AddOns\\Masque\\Libs\\CallbackHandler-1.0\\CallbackHandler-1.0.lua:90\n gatherSpellRanges = <table> {\n }\n nodes = <table> {\n }\n insertDatabaseNode = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:205\n hideTooltip = <function> defined @Interface\\AddOns\\GatherLite\\GatherLite.lua:64\n TimeSinceLastUpdate = 0\n UpdateInterval = 1\n ParseSentData = <function> defined @Interface\\AddOns\\GatherLite\\methods.lua:509\n needMapUpdate = true\n IsNodeInRange = <fun", ["stack"] = "Interface\\AddOns\\GatherLite\\events.lua:41: in function <Interface\\AddOns\\GatherLite\\events.lua:40>", ["session"] = 277, ["counter"] = 3300, }, -- [47]
I don't see a way to disable or alter mini map icons. I want the data to show up on main map but not on mini map. Is there an option for that which I'm missing? Thanks.
The add-on works great, thank you for your work.
I have one annoyance and that is the icons display over top and hide the Find Minerals icons. It's great to know where previous nodes are but Find Minerals should have priority.
Can the icons draw underneath Find Minerals or can you add an option to set opacity on gatherlite minimap icons?
look at this short video -> spam map (open, close, open close) and all icons are replaced after a while
https://files.derpierre65.de/30-08-2019/FlippantAgamaVibrant.mp4
tooltip is alright only the icon is wrong
edit: after /reload are replaced the wrong icons to the correct icons
Debugging mode is on by default.
I've installed the addon on the first day of Classic release and debugging has been on since then. I've been able to turn it off using the command, but I believe it should be off by default.
The opacity of the minimap icons fades to full after a minute or so. On a UI reload the opacity levels appear what have been set, but then fade back to full opacity again.
Some guys in my Guild have got Gatherlite to, we have activate the Guild share. But he told me that he can not see my Herbs I found before.
How does Guild share Work, if it works?
After a while the zone map breaks and is shown as completely "brown". Next time I get it I'll attach a screenshot.
Using 1.1.2
NPCs like this one in Ashenvale spawn a chest upon death that gets tracked + recorded by this addon:
https://classic.wowhead.com/npc=3928/rotting-slime
The chest is this one:
https://classic.wowhead.com/object=19021/rusty-chest
Since they are not spawning in fixed locations, only a certain area (and only spawn on the spot the NPC dies), the location of these chests should not be recorded by this addon.
Hi,
when opening a chest i get the following LUA error:
1x GatherLite\methods.lua:143: attempt to perform arithmetic on local 'coin' (a nil value) GatherLite\methods.lua:143: in function
foundNode'
GatherLite\events.lua:86: in function `OnLootOpened'
GatherLite\events.lua:140: in function <GatherLite\events.lua:130>
Locals:
x = 0.252887
y = 0.487170
mapID = 1420
loot =
After a while the zonemap becomes laggy when it has to load (ie. switch zones). This happens only after a while logged in as far as I can tell. And also probably if there is loads to show on the map.
Using 1.1.2.
If you need my WTF file, I have loads nodes to show in the barrens and elsewhere.
Message: Interface\AddOns\GatherLite\GatherLite.lua:30: table index is nil
Time: Fri Aug 16 01:19:43 2019
Count: 1
Stack: Interface\AddOns\GatherLite\GatherLite.lua:30: table index is nil
Interface\AddOns\GatherLite\GatherLite.lua:30: in main chunk
Locals: name = "GatherLite"
GatherLite =
Hi,
the show loot tables configuration is not working as intended. enabling it for minimap enables it for both, map and minimap. enableing it for worlmap dosen't do anything.
Would be really nice to have a contributor stats view, so you could see totals of who's contributed most nodes... this would allow the gamification of collecting nodes inside the guild, to encourage more nodes to be collected. Also, there could be an option to notify guild every X nodes gathered, or if X nodes are gathered in X minutes to encourage people, and advertise the use of the addon in the guild.
Wowhead and other sites have a huge database of node spawning. This addon could use this information, optionally, don't you think?
Problem probably is how do we get that data and in which form must we feed it to the addon?
Gathering the lockboxes in Windshear Crag at the moment. Gatherer doesn't seem to keep track of them on the minimap.
Playing on Classic, one of my guild members reported seeing a firebloom showing up in the barrens... which I located, but I was in Tanaris at the time. When I looked, I can't see the node in Tanaris, but I can see it in The Barrens, but it is shown as being located by the other member!
He's also reported messages such as:- Swatter found blocked actions: [AddOn: Gatherlite]
I'm concerned that we don't contaminate the logged data.
If for example I see a herb, run towards it and click on it, but only get the "you need to learn Herbalism" error message, I would expect that this addon still records the coordinates of this resource node.
Similar for chests and ores, as soon as I'm close enough to attempt opening/looting/gathering the node, it should be recorded, no matter if it was an actually successful attempt or not.
Please see attached. I upgraded from an older version, but I always delete folder and extract new folders.
Files under WTF were not touched. Disabled all other addons to test as well.
https://www.archaicbinary.net/stuff/minimap-tooltip.PNG
https://www.archaicbinary.net/stuff/map-icons.PNG
Hi there,
First of all, awesome stuff - thx.
A couple of questions regarding node sharing:
Thanks a lot for taking the time!
1.1.7-classic
when ever placing mouse over any node lua error pops up
Message: Interface\AddOns\GatherLite\methods.lua:477: attempt to index local 'classColor' (a nil value)
Time: Fri Sep 6 02:06:34 2019
Count: 2
Stack: Interface\AddOns\GatherLite\methods.lua:477: attempt to index local 'classColor' (a nil value)
[C]: ?
Interface\AddOns\GatherLite\methods.lua:477: in function <Interface\AddOns\GatherLite\methods.lua:447>
Locals:
Debug logging is set to on and the addon produces a lot of chatter in the chat window when accessing a node.
Debugging messages spam chat whenever you open a node or open the map. Is there a command to disable this?
Describe the bug
The world map is not displayed correctly in WoW Classic. As soon as I reload the game the issue disappears for a few minutes, sometimes just for a few seconds until the world map turns black/alpha again.
Based on my own initiative, I am absolutely sure that it is up to GatherLite since I deactivated every single AddOn in my game. In the end the issue got fixed by deactivating GatherLite.
However, since I and many other users would like to continue using this AddOn I would be very grateful if you could take a look at it.
Screenshots
https://ibb.co/dK3CQMN
Best regards,
Vaneko
Hi, is there a way to disable debug for this addon? I downloaded the latest version from today and every time I open the map it logs debug messages to chat.
Thanks for all the work on this addon!
Hello,
I know this is a new experimental version, and I'm very familiar with the gatherer version from 1.12. When you attempt to gather a node that is higher than your skill the node should still appear on the map even though you can't get it. This is to mark the spots to go to later.
Currently this version is not marking higher skill nodes. Maybe this is a limitation from the newer API.
Thank you for making this BTW - I was getting desperate only a week into release! :P
Would be great to have an option to only show certain nodes... if I'm in an area farming for 1 or 2 particular types of items.
Hello! Is here any way to syncing (or backup/restore/copy) database between two PCs?
Like a one PC at home, another in office?
When "finding" herbs for example it shows a yellow dot on the minimap. With the icons from this addon they are covered. Setting the transparency of the icons is a workaround but it would be nice if there was something more "built in".
Great addon by the way, couldn't get gathermate working but this works great!
Hi,
just wanted to let you know that the version is still reporting as @Project-Version@. Would be nice to see the actual installed version.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.