GithubHelp home page GithubHelp logo

magento-imageengine-extension's Introduction

ImageEngine extension for Magento 2

This extension can be installed via composer:

composer require scientiamobile/module-magento2-image-cdn-imageengine

The extension can then be enabled like this:

./bin/magento module:enable ScientiaMobile_IO

Follow the guide in the official ImageEngine documentation

Compatibility

Compatible with Magento Open Source and Adobe Commerce.

Change Log

Version : V1.0.27

  • Updated PHP version constraint, added PHP 8.3 compatibility
  • Compatible with Magento 2.4.7

Version : V1.0.26

  • Compatible with Magento Commerce (tested with Magento Commerce 2.4.5-p1)
  • Readme updates
    • Corrected module enable instruction - issue #21
    • Add Compatibility section

Version : V1.0.25

  • Fix ACL resource definition

Version : V1.0.24

  • Updated PHP version constraint, added PHP 8.2 compatibility
  • Compatible with Magento 2.4.6-p1

Version : V1.0.23

  • Fixed hardcoded media path.
  • Added new config text field for dynamic media folder.
  • Added validation for address URL.

Version : V1.0.22

  • Fixed: Update client hint headers issue #13
  • Issue solved for img-src,script and style are controlled with a content security policy.

Version : V1.0.21

  • Readme updates
  • Compatible with Magento 2.4.5
  • Fixed: Update client hint headers issue #7

magento-imageengine-extension's People

Contributors

akash-evrig avatar bansi-evrig avatar jonarnes avatar kamermans avatar mihaimatei avatar pasichnikroman avatar romanfixstacks avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

pasichnikroman

magento-imageengine-extension's Issues

PHP 8.2

Any plans to support PHP 8.2?

Additional client hints to be added

In addition to the current client hints, I'd like these to be added:

		'sec-ch-ect',
		'sec-ch-ua-full-version',
		'sec-ch-ua-full-version-list',
		'sec-ch-ua-platform-version',
		'sec-ch-ua-arch',
		'sec-ch-ua-wow64',
		'sec-ch-ua-bitness',
		'sec-ch-ua-model'

Acceptance criteria:

The hints must be reflected in both the accept-ch header and permissions-policy header.

wrong description

use composer require scientiamobile/module-magento2-image-cdn-imageengine
instead
composer install scientiamobile/module-magento2-image-cdn-imageengine

PHP 8.3 version bump

SUMMARY:
As a customer I am updating my Magento sites to 2.4.7 and PHP 8.3, but ImageEngine extension for Magento 2 does not support PHP 8.3.

The latest release of ImageEngine extension for Magento 2, version 1.0.26, does not list PHP 8.3 as supported:
scientiamobile/module-magento2-image-cdn-imageengine - Packagist

Magento added PHP 8.3 support starting with release 2.4.7:
System requirements | Adobe Commerce
Magento Open Source 2.4.7 release notes | Adobe Commerce

Verify that the module works on newer PHP versions.

Instructions have typo for installing module

The composer instruction is correct, but the Magento name of the module is not the same. This is the line that is failing for me:

magento module:enable scientiamobile/module-magento2-image-cdn-imageengine

That gives the error Unknown module(s): 'scientiamobile/module-magento2-image-cdn-imageengine'

It looks like the composer packagist string got used instead of the module vendor/name. Looking in registration.php, I can see that the Magento module name is ScientiaMobile_IO. Also, as the previous command was designed to be run from the top-level, it's common to run magento from there too, making the correct line:

./bin/magento module:enable ScientiaMobile_IO

Though this line is commonly skipped as just running ./bin/magento setup:upgrade will enable the module and also install it. Without any data or schema instructions, this is not required, but in case you later have this it's good to include in the instructions.

Update client hint headers

See

$response->setHeader('Accept-CH', 'viewport-width, width, dpr, ect');
$response->setHeader('Permissions-Policy', "ch-viewport-width=(\"{$imageEngineUrl}\"), ch-width=(\"{$imageEngineUrl}\"), ch-dpr=(\"{$imageEngineUrl}\"), ch-ect=(\"{$imageEngineUrl}\"), ch-downlink=(\"{$imageEngineUrl}\")");

The name of the headers is updated in the spec.

Values in the accept-ch header should be:

  • sec-ch-dpr
  • sec-ch-width
  • sec-ch-viewport-width

(ect should be removed)

Values in Permissions-Policy header should correspond to the values in the accept-ch header:

  • ch-dpr
  • ch-width
  • ch-viewport-width

(remove ch-ect and ch-downlink)

Acceptance criteria:
Request headers sec-ch-dpr sec-ch-width sec-ch-viewport-width are present in requests sent to the imageengine address provided in the permissions policy header

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.