x-govuk / govuk-rspec-helpers Goto Github PK

This could check:

• label is associated with input
• hint is associated with input (if there is one)

Anything else?

We should set up a GitHub workflow which auto publishes to rubygems (when tagged?).

See publish.yml from the govuk-components repo for an example.

@peteryates would you mind helping with this?

The Design System guidance for buttons says:

If you are working in production and research shows that users are frequently sending information twice, you can configure the button to ignore the second click.

To do this, set the data-prevent-double-click attribute to true.

However it also says:

In the case of slow connections, aim to give the user information about what’s happening, for example, by showing a loading spinner or a modal, before using data-prevent-double-click.

So we shouldn't expect it to be set on every button. Instead, it could be opt-in?

  click_govuk_button("Send", prevent_double_click: true)

cc @peteryates @paulrobertlloyd

The Design System guidance for Buttons says:

Use a default button for the main call to action on a page.

Avoid using multiple default buttons on a single page. Having more than one main call to action reduces their impact, and makes it harder for users to know what to do next.

We could consider checking for this. However the guidance is only "avoid" rather than a hard rule, so it might need to be overridden.

These attributes should be present to avoid the risk of reverse tabnapping. See guidance.

Following the addition of fill_in_govuk_text_field in #12 we should add a similar fill_in_govuk_password_field helper.

As well as checking that type=password, this could additionally check that:

• autocomplete="new-password" or autocomplete="current-password"
• spellcheck="false"

       Error message ‘Personal details not marked as complete’ links to #personal_details but no input field has this ID or name

The thing is that, in this instance, #personal_details is a link to another page where the error can be fixed:

<a name="personal_details" class="govuk-link" href="/trainees/ZWV3EDmJtXJqYSfkFv1GY8bi/personal-details/edit">Continue section<span class="govuk-visually-hidden"> personal details</span></a>

Following the addition of fill_in_govuk_text_field in #12 we should add a similar fill_in_govuk_email_field helper.

As well as checking that type="email", this could additionally check that:

• autocomplete="email" (could be opt-in or opt-out as you wouldn't want this if asking for someone else’s email)
• spellcheck="false"

This is what I see, and what I don't want to see:

Title tag is missing the error prefix: ‘
         Error: Check trainee record - Register trainee teachers - GOV.UK
       ’

The click_govuk_button helper should also work with <input type="submit">, mirroring the behaviour of click_button.

Following the addition of fill_in_govuk_text_field in #12 we should add a similar fill_in_govuk_telephone_number_field helper (or maybe fill_in_govuk_tel_field?).

As well as checking that type="tel", this could additionally check that:

• autocomplete="tel" (could be opt-in or opt-out as you wouldn't want this if asking for someone else’s phone number)

@paulrobertlloyd has volunteered. 😁