GithubHelp home page GithubHelp logo

Comments (8)

mathrack avatar mathrack commented on August 16, 2024

Hello,

I think you are correct. With the implicit time scheme for the y viscous term, one gets :
$p = \phi + \frac{\Delta t}{2 Re} \partial_{yy} \phi$ when using Crank-Nicolson
and $p = \phi + \frac{\Delta t}{Re} \partial_{yy} \phi$ when using implicit Euler

from incompact3d.

mattfalcone1997 avatar mattfalcone1997 commented on August 16, 2024

Hi,

Thanks for your response. I was wondering whether this would subsequently require modification of the visualisation so that the pressure in the binary file corresponds to the physical pressure. This is also relevant for the statistics.

from incompact3d.

mathrack avatar mathrack commented on August 16, 2024

This definition of the pressure is selected so that when summing prediction and correction and inserting $p$ instead of $\phi$, the predicted velocity does not appear in the viscous term.

Regarding the exact meaning of physical pressure in the framework of incompressible flows, ...

from incompact3d.

mattfalcone1997 avatar mattfalcone1997 commented on August 16, 2024

I am only concerned with whether the pressure output in postprocessing should be modified to account for the implicit scheme. I do not believe that this is done at the moment (it seems that $\phi$ is output rather than $p$, although I may be wrong).

from incompact3d.

mathrack avatar mathrack commented on August 16, 2024

The current code outputs $\phi$ and not $p$ when using the implicit scheme.

from incompact3d.

mattfalcone1997 avatar mattfalcone1997 commented on August 16, 2024

Okay, thanks for the clarification. Is this something that should/will be updated at a future point? I am not sure how important this is as the difference is $O(\Delta t)$.

from incompact3d.

mathrack avatar mathrack commented on August 16, 2024

I am not planning to open a PR for this modification. The estimation of $\partial_{yy} \phi$ could be inserted just before the call to transpose_y_to_x : https://github.com/xcompact3d/Incompact3d/blob/master/src/visu.f90#L245

from incompact3d.

mattfalcone1997 avatar mattfalcone1997 commented on August 16, 2024

Thanks for your help. I may have a play around with this. I am happy to close this now.

from incompact3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.