Comments (5)
I think the strongest argument is probably to not break backwards compatibility (even though pyxdf is relatively new). But other than that, and acknowledging that the verbose flag was probably carried over from some MATLAB code, it's more convenient to pass a bool into a verbose flag than to work out and manicure some configurable per-module logging setup, and pass the bool into that.
I think this package is mostly useful for data scientists and neuroscientists, who I think appreciate a quick solution that gets the job done without much software engineering -- or to not necessarily technical end users of larger packages in the style of EEGLAB or MNE, where a lot of the details and responsible modules are sometimes obscure to them, but one can at least hope that all the options of the underlying import functions are exposed somehow by that kind of software.
Unfortunately there's only a single "debug" log level in Python, and pyxdf is rather spammy at that level, making application-wide debug logs pretty hard to traverse out of the box without such a facility in place.
from pyxdf.
Are you advocating for not using the logger at all? Or only when verbose=True?
from pyxdf.
IIRC it was just suppressing some of logger messages when set to False (probably all, but that's maybe a bit too much). We could make it suppress just the detailed per-chunk messages if False.
from pyxdf.
Can we default to verbose=True? People who rely on logger entirely might want to ignore the verbose argument yet still get the debug statements (because that's how they configured their logger). If so then the verbose
argument would effectively be equivalent to allow_debug_logging
, though we won't name it that.
Relevant link for logging levels
from pyxdf.
I think that would make sense.
from pyxdf.
Related Issues (20)
- error: unpack requires a buffer of 4 bytes HOT 11
- Opening .xdf generated by LabRecorder HOT 15
- We shouldn't be rounding nominal_srate in load_xdf HOT 6
- Clean up branches HOT 1
- XDF.jl (Julia importer) HOT 4
- xdf_load does not synchronize clocks HOT 8
- Rename master -> main HOT 2
- jooc: why are some values in stream meta-data lists of dicts and some just dicts? HOT 2
- unpack requires a buffer of 8 bytes HOT 7
- Merge streams HOT 2
- Nominal vs. effective sampling rate HOT 25
- Error when dejitter_timestamps=False on stream without samples HOT 6
- "Reading chunk length error" after a Python crash at the end of the recording, any solution ? HOT 5
- OSError: Invalid XDF file HOT 5
- Make progress bar HOT 2
- Incompatible with numpy 1.24
- Azure Pipelines broken? HOT 6
- Single PC clock offset vs. latency and jitter HOT 10
- Possible bug with _clock_sync and clock reset detection HOT 2
- 2-n order drift correction
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyxdf.