xephorium / greedy

LaunchCode Java CS50 Program #2

Greedy

LaunchCode Java CS50 Problem Set #5

Directory Notes:

• 'Greedy.java' (contains main) can be found in the src/main/java/com/xephorium/greedy directory.

greedy's Issues

Consider no setters on ChangeMaker

Hey Chris,

It took me a second to figure out the direction you were going with the prototypes and singletons. It wasn't my first thought, but it works! It's a fresh design. Also, props on doing the research to figure out prototypes.

Using ChangeMaker as a prototype is nice because you discard all the previous state with each new change dispense. One thing to consider would be to remove the setters from that class and make the object immutable. You did a great job using the constructor to populate the required information right from the start. Your code will be simpler if you just create a new ChangeMaker each time.

If you do go that route, I would also advise giving ChangeMaker a factory and removing the it from the spring configuration. You could put the ChangeMaker factory in Spring, but it wouldn't make sense to have both.

Cheers,
Mike

assertEquals

Hey Chris,

I really love the work you did with the unit tests. Great job really embracing TDD.

One small note would be to consider using assertEquals instead of assertTrue. assertEquals is definitely the "industry de facto" for tests. It also gives better output when a test fails (It says "expect 5, but got 2").

Tests look good.

Cheers,
Mike