xeron / xeron-macports Goto Github PK

Hi!

I'm upstream for dpkg, and I check downstream modifications from time to time (see https://wiki.debian.org/Teams/Dpkg/Downstream). I noticed in http://trac.macports.org/ticket/39018 that you were the last to try to update dpkg to the 1.17.x branch in MacPorts which would be really nice! Here are some quick comments on the patches.

In the Portfile:

• configure should check already if -Wvla is usable and skip it otherwise.
• In principle the build should be warnings clean, if there's any I'd like to know and fix them. So no need for the -Wmissing-declarations removal either?
• There should be no need to replace /etc/dpkg, it's instantiated from the configure paths into scripts/Dpkg.pm from scripts/Makefile.am now.
• There is no AC_ERROR usage anymore, the replace can be dropped.

In configure:

• Why the addition of dejagnu? dpkg does not use it.
• Why the gettext version bump?
• Why the AC_PROG_CC gymnastics? AFAIK the macro should handle user setting CC.
• Why the INSTALL gymnastics? Are those still needed?
• Why the AC_PROG_LEX to AM_PROG_LEX switch, that seems obsolete?
• There are some seemingly unnecessary space changes in configure macro arguments.
• Why the addition of AX_CHECK_GNU_MAKE, it should work by simply setting MAKE=gmake.
• Why the AC_OBJEXT and AC_EXEEXT macros? Those are obsolete.
• The C99 feature checks should be unneeded, there's a dpkg macro doing that already.
• Most of the other type and function macros seem unnecessary, several are already checked by dpkg macros, for the functions, if lib/compat does not have a replacement, then there's no much point in checking for them.
• The patch for tarfn is now unnecessary, it already supports GNU tar format.
• You probably also want to patch the gzip invocation using --rsyncable, as that's unfortunately a patches option in Debian and derivatives gzip package. :( I should eventually fix that properly, though.
• The patches for remove.c and archive.c should now be unnecessary.