oauthtask's People
Contributors
Stargazers
Watchers
oauthtask's Issues
Design mistakes and some suggestions
- don't store mapping between client_id and client_secret in memory. You will lose everything when your program shuts down for some reasons, considering DB such as MySQL or noSQL such as mongo to persist them. For those temporary information such as author_code, Redis is a good choice.
- For redirect url, client_id should be seen as a request param not a path param. So it's meaningless to store the mapping between them.
- Your host image website and your client website are heavily coupled. It should be seen as two separate parts.
- Your big picture about the oauth flow is correct, but the routers are full of problem because of the coupling between your host image service and client. Decouple them and try it again.
- It's better to encapsulate your sql-related instructions.
- It's better to divided your whole codes into multiple packages, which makes your program more readable and more maintainable.
- session is a good choice of storing http state information. However, it also consumes your valuable server resources. It's a better way to store these less important info in cookies or authenticate user via jwt token.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.