xkeeper0 / jul Goto Github PK

semantic html says <code> should be for inline code, or wrapped as <pre><code> ... </code></pre> for multi-line / block level blocks of code.

this also lets us move from using <tt> (deprecated) to <code> for inline code stuff

Using the checkbox trick to show/hide a "confirm" link for sticking/closing/trashing a thread would make it more difficult to accidentally trigger these by fat-fingering the screen (or links).

this is bad for hopefully obvious reasons

Right now, the only mechanism to get an account recovered is to email me directly, and that sucks.

It also requires you to attempt logging in 5 times, which... IP bans you with the message about recovery. This is really awful.

Currently the forum encoding is (nothing at all), which means that everyone's browser tries to guess and usually fucks up. Changing it would be easy, except for the part where all the old text is in the database and setting a meta-tag for UTF8 would break all the old shit. Oops.

Need to look into converting the db assets at some point.

minor issue but one of Those Things
https://jul.rustedlogic.net/thread.php?id=18727

Ikachan, the greatest excuse for a major bugfix, is lacking a z-index now. Formerly he would appear above most post layouts but now apparently likes to sneak in behind them, making him disappear.

Mostly silly really, but still something that at some point may want to be corrected.

There's a bunch of x_hacks['host'] that were added long ago to support running the code in two "modes". This is no longer relevant so it's time to get rid of most of them...

The website automatically places <br> tags inside these tags just like anywhere else. <pre> tags currently have a fix which works I guess, but <style> tags actually need to have an exception added somewhere in the code.

Otherwise, custom layouts can't have linebreaks in them (.ran_s3_post becomes <br> .ran_s3_post) unless they use an @import tag to import a .css file.

Since dofilters() in lib/functions.php executes its filters in order, only once, it's possible to use some later filters to bypass earlier ones, e.g.:

<scrautoplayipt>alert("Javascript injection!")</scrautoplayipt>

%BZZZ% also makes it possible to inject syntactically script, though there may not be any way to make it execute since it will always begin with a call to a nonexistent function.

fairly easily fixable with https://www.php.net/manual/en/function.date-default-timezone-set.php

might allow moving ctime() to just time()

For links that link directly to a specific post (like, uh, new replies or the "link" tool) it should probably use the actual post in question

of course some work will need to be done to make sure it doesn't give away posts that you shouldn't be able to see

new thread/new reply has a hidden password field in the event someone wants to use an alternate account. this feature can probably be stripped, or if nothing else make the password field only added in the event that someone chooses to do so.

right now it causes autocomplete to fill it in, which makes auth fail (no username specified) and gives an unhelpful "unauthorized to post" message

As far as I can tell the only current way to manage forums and categories involves direct MySQL access, so I ported over a management page I wrote along with the two support files. You can add, remove, or edit categories and forums, as well as manage local moderators.

http://sukasa.kicks-ass.org/manageforums_port.zip

like in the title is it possible for user to remove http://jul.rustedlogic.net/images/squid.png ? I would like it to be hidden at the very least.

Basically title. Not sure if it requires moderator access, but posting in a thread that is sticky will cause it to become unsticky (or whatever you would call it). Oops.

due to the lack of encoding specified, htmlspecialchars() chokes and, instead of producing anything useful, returns an empty string. thanks.

more information available here:
http://jul.rustedlogic.net/thread.php?id=17207

online.php can already do this if you give it an absurd 'within x seconds' value but there's no pagination and etc.

Instead of having: Pages: 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 instead we could have either of these two solutions (or any variation thereof).

On the left is the way SMWC is doing it, by having a dropdown to go to a specific page, and on the right is my/your suggestion from a year ago.

Currently saved very ugly as strings fully dependent on the editor's current name and timezone settings:
$edited =" (last edited by $loguser[name] at ".date("m-d-y h:i A",ctime()).")";
Fix this. Two new columns for posts (timestamp, editor) would suffice, but we could implement edit history too, sure.

What it says on the tin 💯❤️

Right now there is a mixture of raw mysql_...() commands and commands run through a mysql pseudo-class. these should be replaced with a pdo-based class (and queries redone to use prepared statements).

the faq is a bit outdated and a little weird so this is an issue to update it, finally

Right now, the only fonts specified are Verdana and Tahoma (maybe on a per-scheme basis?); there should be adequate fallbacks, even if it's just to sans-serif, because right now the browser can and will fall back to Ugly Serif Garbage.

New pronoun field for profiles and display in threads

When somebody posts an image, scrape it and re-host it locally to prevent any more photobuckets. Linkrot is hell.

A date format is already set in layout (and overwritten somewhere too), but apparently changing it messes some things up:
$dateformat='m-d-y h:i:s A';
$dateshort='m-d-y';
Ideally it should be user-configurable, which would require a new column in the database.

maybe some day we'll move to PDO :')

There are a few characters that act weird when creating a poll. Specifically:

\ ' " will create another \ character before it in the "Question:" and "Briefing:" boxes (appearing as \ ' and ").

& " < > will get replaced by &amp ; &quot ; &lt ; &gt ; respectively (without the spaces). It seems like it is replacing a few HTML characters with their entities, but not all of them (é is not replaced by anything).

I don't know if I am doing this right.

Or at least make Ika smile again

Warning: Use of undefined constant xxxxx - assumed 'xxxxx' (this will throw an Error in a future version of PHP) in [...]

These are everywhere... 😑 Most have been fixed but there's still a bunch laying around.

nobody in their right mind is going to run an ancient java-based irc client (not to mention that I already deleted it oops)

A tag for the post mood number. Would enable layouts with pictures or colors changing according to the post mood, not just the avatar.

I remember trying to do it myself years ago and having some issues, but it should be possible. Note that it needs to update when you edit the post.

basically to make inserted images using bbcode automatically downscale if they are too big

per http://jul.rustedlogic.net/thread.php?id=18730 (see how easy it is to request a feature)

https://github.com/Xkeeper0/jul/blob/develop/edituser.php#L186

It's extremely likely that when you're using edituser.php, you're editing a user that isn't yourself. However, using $dateformat here will stick your date formatting in the fields instead of theirs, which obviously shouldn't happen.

Additionally, the box for the shortened date format uses dateformat too instead of dateshort, which means that field contains the wrong data from the wrong user; double whammy there. =p

https://github.com/Xkeeper0/jul/blob/master/lib/function.php#L60

appending ?die=1 to a URL would trigger the "request denied" screen with the cookie ban and logging (which normally should only be triggered when the firewall says so, I guess)

Seen on: https://jul.rustedlogic.net/thread.php?id=18227&page=3

The first three posts on the page have no wrapping div. Also, there's no identifying class name on the post body - ideally, the div would have class=post.

<table width="100%">...title...</table>
<table width="100%">...pages...</table>
<div style="position:relative">
	</div>
<table class="table" cellspacing="0">post</table>
<table class="table" cellspacing="0">post</table>
<table class="table" cellspacing="0">post</table>
<div style="position:relative"><table class="table" cellspacing="0">post</table></div>
<div style="position:relative"><table class="table" cellspacing="0">post</table></div>
<div style="position:relative"><table class="table" cellspacing="0">post</table></div>

The theme "Hydra's Blue Thing (V2)" will reset a user's custom date format (in the Edit Profile page) to "m-d-y h:i" and your custom short date format to "m-d-y", and it also won't allow you to change it.

The only way to change the custom date format back is to switch to another theme.

Breaks my layout because I use tags in class names to avoid clashing layouts on the same page.

Really tiny font, only visible by selecting. They're way bad