xrandox / tehstrails Goto Github PK

While working on a parser for my overlay project I noticed that you appear to be missing a trail file:
Data/TehsTrails/TyriaTrails/completiontrails/TheGroveInstance1.trl: https://github.com/xrandox/TehsTrails/blob/main/TehsTrails/TehsTrails.xml#L8112

While I appreciate these are tucked away beneath the map they do appear as if a marker is missing. Might I suggest using a 1 pixel by 1 pixel .png file that is just transparent for it.

GW2TacO shows its default marker in Harathi Hinterlands and looks like your main Common Markers are missing the

<MarkerCategory name="talk" DisplayName="Talk" iconFile="Data/TehsTrails/Markers/Talk.png" iconSize="0.75"/>

This was the offending marker

<POI MapID="17" xpos="655.842" ypos="25.1039" zpos="-749.273" type="tt.mc.cm.rm.talk" GUID="LWHDdPosM0OKXSXzFHKg3A==" info="This heart will be completed after teleporting to the Arrow waypoint." infoRange="20.0"/>

BlishHUD seems to handle this more gracefully and does not display any issue.

at line 1692,

<POI MapID="19" xpos=" -54.0497" ypos="43.6899" zpos="-263.195" type="tt.mc.cm.rm.waypoints" GUID="nrTgPIqKEkOWLj54XtTtCQ=="/>

there's a space between xpos=" and -54 which made the parsing the whole file fail xD. such a sneaky little silly thing.

the iconFile tag attribute refers to this paths. but the case of the image names is wrong. eg: Vista.png is present as vista.png in the folder.
/Data/MapCompletion/General/Vista.png,
/Data/MapCompletion/WaypointMarkers/WPHeart.png
/Data/MapCompletion/General/heartspecific/Threaten.png,
/Data/MapCompletion/General/heartspecific/Cheer.png,
/Data/MapCompletion/General/heartspecific/Bow.png,

both of these categories are referred by POI tags, but these categories do not exist. a simple ctrl +f should help you find this
tt.mc.cm.rm.ppr_m
tt.mc.cm.rm.ppr_r

both of these trails exist, but their name has a small case of O in the TrailOfShame.trl part.
Data/MapCompletion/Trails/trailsofshame/LornarsPassTrailOfShame.trl,
Data/MapCompletion/Trails/trailsofshame/FrostgorgeSoundTrailOfShame.trl,

and finally, The trail tags don't have a guid. i made the parser generate new guids like taco/blish, but if you are fine with it, i would love for guid to be a required attribute.

• Possible Mislabel - https://discordapp.com/channels/580908046364966922/698338598763626557/763097700580458498
• Possible Missing Marker - https://discordapp.com/channels/580908046364966922/698338598763626557/763093341168336938

Just checking out this pack and it's really nicely done, thank you. The only thing that is obviously missing to me, is masteries. I hope you'd consider adding these! Either way, thanks for your work.

As you can see above the Teh trails aren't showing up on the minimap like other waypoint packs. Tested With Tekkits and Reactif and they both show on minimap. Not sure if this is a user error or not.

Your trail missed some of the Starlight Lanterns in Amnytas.

• Bastion of Balance, North of Harmony Green.
• Bastion of Strength, South West of Spellcrafting Workshop.

• Verdant Brink

• Auric Basin

• Tangled Depths

• Crystal Oasis

• Desert Highlands

• Elon Riverlands

• The Desolation

• Add Dark Blue trail to colored trails
• Gendarran Fields: Vista just north of Ascalon Settlement WP is missing a marker, [&BI8BAAA=]

• Add Heart Descriptions....to every heart.... :pepehands:
• Add Zone - Hunting Lodge Hill - Queensdale
• Add Zone - Skritt Cave Queen's Forest - Queensdale
• Add Zone - Wolf Cave - Snowdens
• Add Zone - Grawl Area - Snowdens
• Add Zone - Spider Eggs - Plains of Ashford
• Add Zone - Svanir Cliff - Wayfarer Foothills
• Check if Full Inv still works in Harathi
• Ettin Answers in Queensdale
• Food/drink orders are not random in Lornar's, label them
• Stone Trade Labels in Wayfarer
• Add blurb about "Learn the way of the Kodan" - https://discordapp.com/channels/580908046364966922/698338598763626557/760545818259882044