xsavitar / url-shortener Goto Github PK

Travis CI should be setup for the repo / project for automated testing to be done before review is carried out on PR and/or the project. Consider a minimum PHP version of 5.6 for the project.

When the long link is gotten from the browser, there should be a check for whether the link already exist in the DB. If its found in the DB, then the application should just returned its corresponding short link else it should then do the hashing and return the short link in the browser.

After shortening URL in production: https://tools.wmflabs.org/durl-shortener/shortener.php, the short URL doesn't redirect to the long URL. NOTE: however, this works in localhost, so some debugging needs to be done to figure out why it's not working in production / test server.

Do a solid README.md for how the project can be setup locally or on deployment. To do this, one must have to understand how the project works so that steps will not be misleading.

Looking at the db-connection file in php-scripts folder, you can clearly see that there are 2 configurations for connecting to the DB. There is one for localhost and another for tool labs (deployment env). Also, if you look at the shortener.php in the root directory, you will see that;
$LINK = "tools.wmflabs.org/durl-shortener/shortener.php/" which is only valid on tool labs. But when used on localhost, we need something like this:
$LINK = "localhost:3000/shortener.php" where 3000 is the localhost deployment port. So check files that have link that point to tool labs and create a local host version.

You can decide to make the tool labs link variable like this: $LINK_TL and the localhost variable like this: $LINK_LH.

When using Chrome browser, the url-shortner site opens well but does not when using firefox. It reports erros like:
Firefox has detected that the server is redirecting the request for this address in a way that will never complete.

• This problem can sometimes be caused by disabling or refusing to accept cookies.
  

Codes for connecting to database is really procedural and needs to be changed to an object oriented paradigm. So a class for this operation should be created and used in the codes.

On production it returns something like localhost:3000/shortener.php/zdjmmwiy and writes it to DB so it's impossible to get the right redirect.