GithubHelp home page GithubHelp logo

yalantis / guillotinemenu Goto Github PK

View Code? Open in Web Editor NEW
2.9K 117.0 253.0 987 KB

Our Guillotine Menu Transitioning Animation implemented in Swift reminds a bit of a notorious killing machine.

Home Page: https://yalantis.com/

License: MIT License

Swift 96.72% Ruby 3.28%
ios swift animation protocol cocoapods guillotinemenu transition-animation yalantis

guillotinemenu's People

Contributors

darkkrye avatar edbaev avatar egorsobko avatar joekr avatar makstheawesome avatar maximletushov avatar mrcompoteee avatar naeemshaikh90 avatar pravdaevgen avatar rnkyr avatar serejahh avatar sergey-prikhodko avatar vodolazkyi avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

guillotinemenu's Issues

Dismiss Menu

When I close the menu ViewController, my main view is disable.
Can you help me?

CococaPods support

Hi,

I know it's "coming soon", but do you think to release a pod soon? It will be great to have one.

After Animation UI doesn't respond for 1-2 seconds

After that animation is finished in the two modes : Presentation & Dismissal , the UI doesn't respond :

  • you can not select anything ..for example for the demo application you can not neither select the menu button nor scrolling the tableView.

Problem when run in iOS8.2 by iPhone6

Using Xcode 7.2 + swift2.0
Thank you for your menu, it's so cool
But when i try it in iPhone6 using iOS8.2, it have big problem.
Just display :
VC: viewWillAppear
VC: viewDidAppear
Menu: viewWillAppear
VC: viewWillDisappear
willStartPresentation
img_0221

Button Frame very small

When i press the bar button to open the menu view, the same button when pressed is very small. I just can't make the tab button bar button bigger.

Swift3

Recently, I updated swift3 and Xcode 8.
well, I'm not yet understanding whole error code, but some error appears on framework source code related to animation.

Dismiss animation is not fast enough

when i set animationDuration lower than 0.15, dismiss animation will never stop. How could I make animation faster and without dismiss bug?

thank you.

Preview not working

Report a bug

What did you do?

Opened Preview link in README and saw: Cannot proxy the given URL

Objective-C Version

Have you plan to code an Objective-C version of this great control?

Thanks,
Matteo

XCODE 6.3

Good Day,

I ported my code to XCode 6.3 and got the following error, at runtime:

Could not find a segue class named 'GuillotineMenuSegue'

When adding constrain on button on menu controller in ios 10 , menu goes down

i use guillotineMenu in my application, it's work fine before ios 9, but when i try my application on ios 10,my menu item goes down. This problem comes when only i aaply constrain on my menu items. If i remove all constrain it works fine. my menu looks like below image url-
https://mail.google.com/mail/?ui=2&ik=b52cec5c23&view=fimg&th=15779dcf62a6d650&attid=0.1.3&disp=emb&attbid=ANGjdJ9ikGsbkM_xZhUJbIj61Ev2392UL5SyHA7xeI9oC7UlsMKAL6damrcsVs_j7U5ZzeG4JyaVmLt_V6DEJaTeU5ChW3fzlEluLq-UoGeW36Yn1vXDv4KqzivAzyw&sz=s0-l75-ft&ats=1475487755862&rm=15779dcf62a6d650&zw&atsh=1

How to give showmen segue?

It's working with animation like example for me, I think segue didn't given properly in my project.
how to give showmen segue to menu view controller?

Menu UIButton -> UIBarButtonItem

I tried to add the GuillotineMenu to my app but i saw the menu button inside the menu view never appears because it returns an UIButton in the dismissButton variable and the button in the navigation bar is an UIBarButtonItem. I don't know if it's something i have to change or is something from a newer version of Xcode because i couldn't have access to the button within the uibarbuttonitem in the storyboard. I even had to change the code in the viewcontroller when i want to present the menu (presentationAnimator.presentButton = sender.customView as? UIButton) because the sender is an UIBarButtonItem.

Please let me know about this issue. If i must change something on my side or it's something different.

Thanks!

Your Environment

  • [X ] Version of the component: latest
  • [X ] Swift version: 3
  • [X ] iOS version: 10.2
  • [X ] Xcode version: 8.2.1 (8C1002)

Navigation Controller won't come back up

I was wondering is there a way you can get the navigation controller to show again when segueing normally to another viewController because when I do so the navigation controller disappears.

Use of unresolved identifier in ViewControllerTransitioningDelegate

Report

I copied the code from the example project and it won't run. The example project will run though. So Basically it is saying that there is errors of "use of unresolved identifier presentationAnimator and cellHeight.

screen shot 2017-05-25 at 6 36 34 am

As I said, the example project runs but not the copied code. I have included it in pod file and installed it and imported it.

What can I do to resolve this?

  • Version of the component: commit 39f8585
  • Swift version: 3
  • iOS version: 10
  • Device: Simulator iPhone 6s
  • Xcode version: 8.3
  • If you use Cocoapods: _run pod env | pbcopy and no result
  • If you use Carthage: _run carthage version | pbcopy and carthage not installed

Access to GuillotineMenuViewController

Dear Yalantis

Thanks for your excellent control.

I have integrated it into my Swift Project. However the compiler complained that GuillotineMenuViewController is undeclared.

To be able to compile successfully, I had to change the access in GuillotineMenuViewController.swift to public, e.g.

public class GuillotineMenuViewController: UIViewController {

instead of

class GuillotineMenuViewController: UIViewController {

In addition some of the routines and properties should also be public.

Kind Regards
Graham

how to change height of menu drawer

Report

The more information you provide, the faster we can help you.

⚠️ Select what you want - a feature request or report a bug. Please remove the section you aren't interested in.

A feature request

What do you want to add?

Please describe what you want to add to the component.

How should it look like?

Please add images.

Report a bug

What did you do?

Please replace this with what you did.

What did you expect to happen?

Please replace this with what you expected to happen.

What happened instead?

Please replace this with what happened instead.

Your Environment

  • Version of the component: insert here
  • Swift version: insert here
  • iOS version: insert here
  • Device: insert here
  • Xcode version: insert here
  • If you use Cocoapods: run pod env | pbcopy and insert here
  • If you use Carthage: run carthage version | pbcopy and insert here

Project that demonstrates the bug

Please add a link to a project we can download that reproduces the bug.

Speeding up animation

Hi there,

I love your menu! I am trying to use it in my IPAD only app. The animation is very slow in this case. I have tried setting :
private let duration = 0.6
Had no impact. Please give me an indication how to speed up the animation?

duration time and spring effect!

  1. I find to adjust my project of speed duration time.
    But If I'am change the time from 0.6 to 0.1, then simulator got a some bug at disappear page to up side. not remove completely.

so, what should I change time to 0.1 how can I do?

  1. second I can not find spring effect part!
    could please where is that?

I feel the effect of spring effect so much..

Please help me

Report

The more information you provide, the faster we can help you.

⚠️ Select what you want - a feature request or report a bug. Please remove the section you aren't interested in.

A feature request

What do you want to add?

Please describe what you want to add to the component.

How should it look like?

Please add images.

Report a bug

What did you do?

Please replace this with what you did.

What did you expect to happen?

Please replace this with what you expected to happen.

What happened instead?

When i click in FEED button, it is return to Activity UI, ??????????

Your Environment

  • Version of the component: insert here
  • Swift version: 4.0
  • iOS version: insert here
  • Device: insert here
  • Xcode version: 9.4.1
  • If you use Cocoapods: run pod env | pbcopy and insert here
  • If you use Carthage: run carthage version | pbcopy and insert here

Project that demonstrates the bug

Please add a link to a project we can download that reproduces the bug.

iPhone 6S leaning screen

Hi !

I have exactly the same problem than this : #17

But I use Xcode 8 and an iPhone 6S with iOS 10.1.1. The Example project works but I don't know why in my project it does not works.
It stops after willStartPresentation.

Thank you for your help !

Change view from menu

Hi :),

Thank you for your menu, it's so cool ^^.
But I don't understand something, how do you do to change view from the menu (from profile button by example) ?
May be i'm too tired lol but i tried all, and nothing works ...
Can you help me ?
Thank you.

Device orientation causes frustration

The screen orientation is set to Portrait and Upside Down.

After the release of swift 2.2 a minor bug has been monitored.

If i open the app holding the device as "portrait" it works as expected.
If i open the app holding the device as "landscape" the menu behaves like pendulum.

I've tested it also in your example, by changing only the screen orientation of your example "GuillotineMenuExample"

error use of undeclared type "guillotineMenuViewController

Thanks in advance for help I probably missed something simple
I am a beging iOS Student I am having trouble manually installing
I get use of undeclared type "guillotineMenuViewController
I searched stack overflow for answers and went over project several times
Using Xcode 6.3 & iOS8.3
My project https://github.com/Ongomobile/GMenu
Just wanted to see if I could get the menu to work first

This is what I did

  1. added Guillotine Menu file and assets from example, copied to project target selected and put under my file with project name

  2. Created ViewController in interface builder and set class to GuillotineMeneViewController, it was in dropdown

  3. In ViewController that comes with single view application I created bar button item and button in interface builder, connected button outlet to code

  4. Controll dragged to GuillotineMenuViewController set segue to Custom and class GuillotineMenu it was in dropdown

  5. In my ViewController I copied nav bar code from example to viewDidLoad, and copied prepare for segue after that

Tried to run and keep getting the error use of undeclared type "guillotineMenuViewController
here is my code from my view controller

import UIKit

class ViewController: UIViewController {

@IBOutlet var barButton: UIButton!

override func viewDidLoad() {
    super.viewDidLoad()
    let navBar = self.navigationController!.navigationBar
    navBar.barTintColor = UIColor(red: 65.0 / 255.0, green: 62.0 / 255.0, blue: 79.0 / 255.0, alpha: 1)
    navBar.titleTextAttributes = [NSForegroundColorAttributeName: UIColor.whiteColor()]
}

override func prepareForSegue(segue: UIStoryboardSegue, sender: AnyObject?) {
    // Your Menu View Controller vew must know the following data for the proper animatio
    let destinationVC = segue.destinationViewController as! GuillotineMenuViewController
    destinationVC.hostNavigationBarHeight = self.navigationController!.navigationBar.frame.size.height
    destinationVC.hostTitleText = self.navigationItem.title
    destinationVC.view.backgroundColor = self.navigationController!.navigationBar.barTintColor
    destinationVC.setMenuButtonWithImage(barButton.imageView!.image!)
}

}

not able to navigate back from menu

I have added the menu through this code. in the menu view, I have one button to navigate to a second view controller. when I dismiss the second view controller menu dismiss icon is not visible in the menu view controller. Kindly help with this.

iOS 7

I don't have an iOS 7 device or simulator but my app must support iOS 7 min.

What part of code base stops it from being compatible with iOS 7. I don't seem to see anything that is iOS 8+

Some options

Can you guys tell me how to speed up the animation and how to make the screen take up only half of the screen when the animation is performed.

Button changes of position when we push on it

Hello there,

Just to let you know, i have experiencing an issue with the button on the top left corner.
When the first VC appears, the button has a good position, but as soon as i push on it to get the second VC, the button move on the maximum top and left corner...
When i push again to get back on the first VC, the button gets back its correct position...
I ve compared between my version and the example... but i don't find anything...

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.