yam-finance / synths-sdk Goto Github PK

Describe the feature request

• Update assets.json with the new ustonks contracts.

Describe the bug:
Fix all warnings and errors that are displayed after yarn lint

Describe the bug:
The readme seems to be a bit misleading, especially the code block for the sdk initialization.

• Market price of Synth from DEX for range (yam-www white line on chart)
• Marketcap from lsp
• TVL from api.yam.finance/tvl
• DEX pool liquidity
• pool volume last 24h

Describe the feature request
We should add our docgen script to our CI workflow.

Let's collect some docgen generators in this thread.

Hey team,

We've noticed that you're referencing a subgraph deployed on The Graph's hosted service in this repository. Just a heads-up: after June 12th, hosted service subgraph endpoints will no longer be available as the offering is being deprecated.

If you are the subgraph owner or maintainer, it's time to upgrade your subgraph to the network. This ensures everything keeps running smoothly and you get access to all the latest features and improvements. Here is a quick guide with all the upgrade steps.

If you're not the subgraph owner or maintainer, check Graph Explorer to see if the subgraph development team has already upgraded to the network. If you don’t find an upgraded subgraph, a friendly nudge to the subgraph development team would be greatly appreciated—it's a quick process that benefits everyone. Here's the upgrade guide with all the necessary steps for the subgraph development team.

Once the subgraph is upgraded to the network, you can create an API key and updated query URL in Subgraph Studio then update this repository to query from the new endpoint, https://api.studio.thegraph.com/query/<ID>/<SUBGRAPH_NAME>/<VERSION>

Need more support or have more questions? Feel free to reach out to [email protected]. We're here to help!

Cheers,

Paka

Eslint shows an issue for the following line. @byterose As the author of this function, you see any reason why we shouldn't remove this?

@typescript-eslint/no-unused-vars

Suggestion would be to replace that line with "," effectively ignoring that parameter during deconstruction.

I also propose removing the console statement:

let me know what you think

Describe the feature request
As discussed with @ElmoArmy it would be cool to have a type for all synths. So a user can see what synths are actually available.

Describe the feature request
Add methods to call the lsp contract.

Describe the feature request
Since the old functions used web3.js we still need to migrate a few methods to ethers.js and add the test for these methods

Describe the feature request
This claim function will be useful for the future.

Note: to plan out the fee to yam treasury implementation.

Hm.. since we will only go with one pool for now it is okay. It might however be helpful if we have multiple pools but until then we already might have everything on-chain.

This just prompted me to think about how we plan on incentivizing pools by different amounts which wouldn't be , that will need to be included here. So I think you are onto something here with a pool type or at least an incentive weight.

Originally posted by @ElmoArmy in #88 (comment)

After reading from asset json and generally everywhere, convert addresses to what is needed according to the function that is using it, for subgraph lowercasing it is needed for example you can lower case the checksummed address before passing it to subgraph.

• custom errors

Integrate Github actions for automated testing.

Describe the feature request
A function that gets the portfolio of a user.