yankouskia / quadratic-equation

Recall school math!

Quadratic equation

Recall school math!

Task

Your task is to implement solveEquation function, wihch solves Quadratic equation. Each equality has exact 2 integer solutions. Return those numbers as ordered array.

Example:

  const solutions = solveEquation('2 * x^2 - 10 * x + 12');
  console.log(solutions); // [2, 3]

Write your code in `src/index.js. Be sure, that all tests are positive. That means you cannot catch any error in tests.

Prepare and test

• Install Node.js
• Clone this repository: git clone https://github.com/yankouskia/quadratic-equation.git
• Go to folder quadratic-equation
• Run npm install in command line
• Run npm test in command line
• You will see the number of passing and failing tests

quadratic-equation's Issues

Tests should not check the order of roots

Tests can be improved.

Now they check that result array is completely equal to expected. But in quadratic equation the order of roots does not matter. So it's better to check length of result array and that it includes first and second roots.

Because I got such failing tests:

AssertionError [ERR_ASSERTION]: [ 4647489, 62156 ] deepEqual [ 62156, 4647489 ]
      + expected - actual
       [
      +  62156
         4647489
      -  62156
       ]

One typo

One typo in README.md.

wihch

It's not an equation.

An equation is written as two expressions, connected by an equals sign ("=")
2 * x^2 - 10 * x + 12 -- is expression
2 * x^2 - 10 * x + 12 = 0 -- is equation