yeo-kexin / pe Goto Github PK

Steps:

1. add n/Brendan Tan p/93211234 s/Commonwealth Secondary School y/pri 6 v/Blk 33 West Coast Rd #21-214 t/3 234-1635

Expected: error to be thrown and show correct command format

Actual: error is not caught, and error will not be shown

Steps:

1. exam add 1 n/Mid Year 2020 d/08/12/2020 s/0/0

Unsure if this should be 0% or 100%?

Actual command:

Command summary:

Steps:

1. attendance add 1 d/31/10/2022 a/present

I think there should be a date constraint (just like the add command) to prevent taking of attendance for future lessons?

Bottom words are unclear

Works fine in .md though!

Works fine in .md though!

In most use cases, there's a step to enter command to list students, with the same extension (list is empty, use case ends). Perhaps this could be replaced with UC05 so there are less repeated steps.

Quote:
"In the meantime, we advise you to refrain from accidentally clearing all data, you could perhaps create a backup json from time to time."

• Slight grammatical error here which may make it tough for readers to understand
• Readers may not understand how to create a backup json. Furthermore, there are 2 .json files which may confuse the reader as to which to make a backup of. Perhaps more details can be given (e.g. navigate to data folder and duplicate both the addressbook and notebook json)

Steps:

1. schedule

It's a trivial issue, but maybe it shouldn't be a possible command since it does the exact same thing?

Maybe it could be explained in terms of admin and academic details as it currently sounds like there's a way to view both details at once which is misleading.

Steps:

1. add n/test p/3214 s/test y/p1 v/test t/3 1200-1300 (index 7)
2. add n/test p/3214 s/test y/p4 v/test t/4 1200-1300 (index 8)
3. edit 8 y/J2

Expected: the student at index 8 to be edited and remain at 8

Actual: the student at index 8 is edited, but has changed index to 7 which is slightly disorienting

Could be better explained in the UG!

Steps:

1. edit 1 n/123456789012345678901234567890123456789012345678901234567890

This is a personal opinion but I found the red words a little tough to read. Perhaps another colour like white may be better?

Steps:

1. exam add 1 n/Mid Year 2020 d/08/12/2021 s/40/60

I don't think it should be possible to add a future exam and specify a score for them? Unless there could be a clarification that this is their target score.

Steps:

1. add n/test p/3214 s/test y/pRI 3 v/test t/5 1200-1300

Expected: succesful addition of student

Actual: error thrown