yii2tech / ar-position Goto Github PK

Please add feature to check if model is first or last in position
isFirst and isLast methods

I have checked the code for PositionBehavior::beforeDelete and the idea (moveLast()) is great, but it seems not to be working.

What steps will reproduce the problem?

Delete a record

What is the expected result?

Position of other elementos to be updated

What do you get instead?

Elements that were after the deleted record keeps their position. I have elements in positions 1 to 10, if deleting the 2nd the third should become 2nd and the same for the rest.

Additional info

We are facing problem when using PositionBehavior in couple with SoftDeleteBehavior.

We want to exclude deleted records from updateAllCounters update:

public function behaviors() {
    return [
        'softDelete' => [
            'class' => SoftDeleteBehavior::className(),
            'softDeleteAttributeValues' => [
                'isDeleted' => true,
            ],
        ],
        'position' => [
            'class' => PositionBehavior::className(),
            'positionAttribute' => 'position',
            'groupAttributes' => [
                'albumListId',
                'isDeleted',
            ],
        ],
    ];
}

But this causes that PositionBehavior updates only deleted records. Yes, I know that changing behaviors order may solve this problem, but this is not a good idea.

I propose adding ability to set a value into groupAttributes like that:

'groupAttributes' => [
    'albumListId',
    'isDeleted' => false,
]

Thank you.

As I undestand all new records are appended to the end of list when positionAttribute is empty in insert scenario.
Is it a good idea to add a new property (for example insertDefaultPosition) when we can choose default inserting position (first or last or even exactly integer position).

When I update groupAttribute behavior put old position to $this->positionOnSave in beforeUpdate event and then saves it in afterSave event instead of keeping the new calculated position (line 435).
I believe there is a wrong unnecessary line:

When trying to position in a null category group I'm getting the following result:

Initial position:
Item 1 -> position 1

After adding item 2:
Item 1 -> position 0
Item 2 -> position 1

Update item 2 for the first time:
Item 1 -> position 0
Item 2 -> position 2

Update item 2 for the second time:
Item 1 -> position 0
Item 2 -> position 0

Solved this issue by changing the line 256 of PositionBehavior.php to this code:

$condition[$attribute] = empty($this->owner->$attribute)?null:$this->owner->$attribute;

model source:

public function movePre($position)
{
      $model = new PositionBehavior();
      $model->positionAttribute = $position;
      $model->groupAttributes = ['project_id'];
      $model->movePrev();
  }

controller source:

public function actionMove($id)
    {
        $position = $this->findModel($id)->position;
        $model = new Projectparts();
        $model->movePre($position);
        return $this->redirect(['projects/index']);
    }

return this: Call to a member function find() on null