yiminghe / css-animation Goto Github PK

Hi,

One of the module on my app uses your module but I get the document is not definederror when webpack build my app.

The issue comes from here

I simply added a typeof document !== 'undefined'check on document but I don't know if there is any side effects ?

PR just here if there is no side effects

This issue on the module which depends on yours

When finding the transition duration, this library should sum the duration and the delay here: https://github.com/yiminghe/css-animation/blob/master/src/index.js#L27

I'm experiencing the following error with 1.6.0 while doing a production build with webpack, reverting to 1.5.0 fixes the problem.

=============
Failed to compile.

./node_modules/antd/es/_util/wave.js
Cannot find module: 'css-animation/es/Event'. Make sure this package is installed.

You can install this package by running: npm install css-animation/es/Event.

To mitigate the issue I added the following to my package.json

"resolutions": {
    "css-animation": "1.5.0"
  }

• ant-design/ant-design#7158
• react-component/react-component.github.io#12

你好，我是一个刚开始从事前端的小白，最近在学习你的css-animation这个源码，收益匪浅。
想请教4个问题，希望大佬百忙之中可以看到：
1、index.js的
node.rcAnimTimeout = setTimeout(() => {
。。。
// 30ms for firefox
}, 30);
这一块，不是很懂，为什么是30ms后，给DOM加上'XXX-active'的样式，且注释是30ms for 火狐，而不是在下一帧requestAnimationFrame时加上'XXX-active'这个样式呢
2、为什么if(active)，需要setTimeout(active, 0);再执行active函数，而不是和start一样立即执行呢？
3、Event.addEndEventListener(node, node.rcEndListener);添加了监听过渡或动画结束的事件，
为什么还需要执行fixBrowserByTimeout(node);用定时器来实现过渡或动画的时间呢？兼容animation/transition不是应该就可以兼容animationend/transitionend了吗，是什么浏览器会不兼容吗
4、fixBrowserByTimeout在计算过渡或动画时间设置的定时器，(time) * 1000 + 200，为什么需要加200ms呢

非常感谢！

hi the recent 1.4.0 release added the "module" field in package.json but now when css-animation is a dependency of a create-react-app project the build fails with

'css-animation' does not contain an export named 'isCssAnimationSupported'.

the issue is that isCssAnimationSupported is exported as a field of the default export
i don't know why but before the package.json modification the following import worked
{isCssAnimationSupported} from "css-animation"

is possible to add the named export:
export isCssAnimationSupported
to be backward compatible?
tnx

isCssAnimationSupported 的判断在服务器端总是 false，但在浏览器端可能是 true。

从而导致两端渲染的结果不一致。

有没有方法让其一致，不产生warning呢？

Hi and thanks for your great work on this project. 👏

Is there any way you could replace the component-classes dependency with something else? It's causing a lot of headaches for me due to component/classes#31 and their conditional requires. There hasn't been any activity over there for more than two years - it is unmaintained.

On a related note, since those require()s are to support IE, what do you think of dropping IE support and just using classList?

var Event = require('./event');
var Css = require('./css');

文件实际上是 Event.js 和 Css.js。

会导致 webpack 报错。

I have saw the usage there but it's too simple to understand how it works. can you provide some specific code? （have check the online example, but I want check the code of the example.

Seems not required by src codes.

https://docs.npmjs.com/files/package.json#license

The property licenses should be license at https://github.com/yiminghe/css-animation/blob/master/package.json#L17

Hi!
I've been using rc-slider package, and I got following error

./node_modules/rc-animate/es/AnimateChild.js
76:11-34 'css-animation' does not contain an export named 'isCssAnimationSupported'.

As listed in npm list command, it uses internally Your package

├─┬ [email protected]
│ ├── [email protected]
│ ├─┬ [email protected]
│ │ └─┬ [email protected]
│ │ ├─┬ [email protected]
│ │ └── [email protected]
│ │ └─┬ [email protected]
│ │ └─┬ [email protected]
│ │ └─┬ [email protected]
│ │ └── [email protected]

Code worked on version 1.3.2 and stopped working on version 1.4.0

In rc-animate package, import from css-animation looks like this:

import cssAnimate, { isCssAnimationSupported } from 'css-animation';

Did something change in the API?