yisaer / benchmark-operator Goto Github PK

Is your feature request related to a problem? Please describe.
It's very easy to forget add an end-of-line at the end of each file. Scripts should be used to do these things. Especially after the CI is ready.

Describe the solution you'd like

Use a script to check end-of-line at the end of file in CI.

Also use a script to fix these kind of problems automatically. (And make fmt should run this script.)

Describe alternatives you've considered
I think we can use tidb-operators' update-EOF script and tidb-operators' check-EOF script directly.

Set security rule for the branch in this repo.

Is your feature request related to a problem? Please describe.
It's very easy to forget add an end-of-line at the end of each file. Scripts should be used to do these things. Especially after the CI is ready.

Describe the solution you'd like

Use a script to check end-of-line at the end of file in CI.

Also use a script to fix these kind of problems automatically. (And make fmt should run this script.)

Describe alternatives you've considered
I think we can use tidb-operators' update-EOF script and tidb-operators' check-EOF script directly.

After #10 done, we should revise the script to expose more configuration.

Is your feature request related to a problem? Please describe.
Currently, make test would fail when running, and I commented it out in pull request #27, because the default tests kubebuilder gave us is not applicable.

Describe the solution you'd like
Write applicable unit tests.

Currently the database remains it's current state after benchmark.
Consider use runDatabaseDestroy.sh to destroy the database to make run multiple tests one-by-one easier.

Add example and doc so that users could use it.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

To make tpccbench API easier integrated with tidbcluster, we should make API expose more tidbcluster meta property.

Add CI support.
I suggest Github Actions.
Example here.