yoctol / eslint-config-yoctol-base Goto Github PK

View Code? Open in Web Editor NEW

2.0 2.0 1.0 306 KB

Yoctol specific base linting rules for ESLint

JavaScript 100.00%

eslint eslint-config

eslint-config-yoctol-base's People

Contributors

Stargazers

Watchers

Forkers

jayd2446

eslint-config-yoctol-base's Issues

[Proposal] no-unused-expressions: 0 (best-practices.js)

In tests, it's helpful when writing some assertions

curly rule discussion

Now it's curly: ['error', 'multi-line'] from eslint-config-airbnb-base

https://github.com/airbnb/javascript/blob/90235cab7c060d69430001cf17aa28ff74da86b4/packages/eslint-config-airbnb-base/rules/best-practices.js#L25-L26

https://eslint.org/docs/rules/curly#multi-line

Any idea whether to change it or not?
@Yoctol/sd @Yoctol/trainer

[Proposal] linebreak-style: 'off'

我們專案常常(好、只有我QQ)跨平台
而 git 就有處理這件事情，我 commit 的都會自動轉換成 unix 形式，
所以我覺得這個可以關掉

https://github.com/airbnb/javascript/blob/ca1124cd8d2e33addbffb3b1743849e2bf774039/packages/eslint-config-airbnb-base/CHANGELOG.md#500--2016-07-24

put build status badge on README

[Proposal] eslint-plugin-import/order

https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

[Proposal] import/newline-after-import: 2

https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md

When Not To Use It
If you like to visually group module imports with its usage, you don't want to use this rule.

我們會常遇到這個狀況嗎

An in-range update of eslint-plugin-import is breaking the build 🚨

The devDependency eslint-plugin-import was updated from `2.18.0` to `2.18.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 14 commits.

b51aa2f Bump to v2.18.1
32704da fix: Improve parse perf when using @typescript-eslint/parser
3b21de6 [Tests] extract common "get parser" logic into test helpers
f4e3f1b prefer-default-export: don't warn on TypeAlias & TSTypeAliasDeclaration
1caa402 [Fix] no-unused-modules: Exclude package "main"/"bin"/"browser" entry points
22d5440 [fix] export: false positive for typescript overloads
5abd5ed [Tests] temporarily disable these failing tests in eslint < 4
752dcd5 [Tests] add missing --no-save to time travel script
d3a3fa5 [Refactor] no-extraneous-dependencies: remove the last bit of lodash
8a38fd4 [Refactor] no-extraneous-dependencies: use Array.isArray instead of lodash
c5078ad [Refactor] importType: remove use of cond
118afd4 no-deprecated: don't run tests for typescript-eslint-parser against ESLint <4
6512110 fix tests for node 4 + fixed lint issues
bb9ba24 no-deprecated TS tests (#1315)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Add prettier configs

[Proposal] "max-len": [2, 99, { "ignorePattern": " // eslint-disable-line " }]

"max-len": ['error', 99, { "ignorePattern": " // eslint-disable-line " }]

is useful in most of cases

Upgrade eslint-config-airbnb-base to v7.1.0

An in-range update of eslint-config-prettier is breaking the build 🚨

The dependency eslint-config-prettier was updated from `6.0.0` to `6.1.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-config-prettier is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 4 commits.

c944458 eslint-config-prettier v6.1.0
e0b6648 Add function-call-argument-newline
3955d29 Update npm packages
61ac63a Fix broken link in changelog

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

npm

package.json

eslint-config-airbnb-base ^14.2.1

eslint-config-prettier ^8.3.0

eslint 7.32.0

eslint-plugin-import 2.24.2

eslint-plugin-prettier 4.0.0

eslint-plugin-sort-imports-es6-autofix 0.6.0

prettier 2.4.1

eslint >=7.7.0

eslint-plugin-import ^2.18.2

eslint-plugin-prettier ^3.1.0 || ^4.0.0

eslint-plugin-sort-imports-es6-autofix ^0.6.0

prettier >=2.0.0

node >=10

travis

.travis.yml

node 12

node 10

Check this box to trigger a request for Renovate to run again on this repository

import/no-unresolved 在 Windows 上有點問題

https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md#200---2016-09-30

Case-sensitivity: now specifically (and optionally) reported by no-unresolved. Other rules will ignore case-mismatches on paths on case-insensitive filesystems. (#311)

看起來是這個引起的我再研究一下之後再去那邊發 issue

[Proposal] import/newline-after-import: 2

An in-range update of eslint is breaking the build 🚨

The devDependency eslint was updated from `5.15.3` to `5.16.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for v5.16.0

dfef227 Build: gensite passes rulesMeta to formatter rendering (#11567) (Kevin Partington)
c06d38c Fix: Allow HTML formatter to handle no meta data (#11566) (Ilya Volodin)
87a5c03 Docs: func-style: clarify when allowArrowFunctions is used (#11548) (Oliver Joseph Ash)
bc3e427 Update: pass rule meta to formatters RFC 10 (#11551) (Chris Meyer)
b452f27 Chore: Update README to pull in reviewer data (#11506) (Nicholas C. Zakas)
afe3d25 Upgrade: Bump js-yaml dependency to fix Denial of Service vulnerability (#11550) (Vernon de Goede)
4fe7eb7 Chore: use nyc instead of istanbul (#11532) (Toru Nagashima)
f16af43 Chore: fix formatters/table test (#11534) (Toru Nagashima)
78358a8 Docs: fix duplicate punctuation in CLI docs (#11528) (Teddy Katz)

Commits

The new version differs by 11 commits.

ded2f94 5.16.0
ea36e13 Build: changelog update for 5.16.0
dfef227 Build: gensite passes rulesMeta to formatter rendering (#11567)
c06d38c Fix: Allow HTML formatter to handle no meta data (#11566)
87a5c03 Docs: func-style: clarify when allowArrowFunctions is used (#11548)
bc3e427 Update: pass rule meta to formatters RFC 10 (#11551)
b452f27 Chore: Update README to pull in reviewer data (#11506)
afe3d25 Upgrade: Bump js-yaml dependency to fix Denial of Service vulnerability (#11550)
4fe7eb7 Chore: use nyc instead of istanbul (#11532)
f16af43 Chore: fix formatters/table test (#11534)
78358a8 Docs: fix duplicate punctuation in CLI docs (#11528)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

[Breaking] complexity ?

是不是該限制一下 http://eslint.org/docs/rules/complexity

An in-range update of eslint is breaking the build 🚨

The devDependency eslint was updated from `6.1.0` to `6.2.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for v6.2.0

fee6acb Update: support bigint and dynamic import (refs #11803) (#11983) (Toru Nagashima)
afd8012 New: noInlineConfig setting (refs eslint/rfcs#22) (#12091) (Toru Nagashima)
3d12378 Update: Fix accessor-pairs to enforce pairs per property in literals (#12062) (Milos Djermanovic)
8cd00b3 New: function-call-argument-newline (#12024) (finico)
30ebf92 Fix: prefer-template autofix produces syntax error with octal escapes (#12085) (Milos Djermanovic)
13c3988 Fix: Check literal type explicitly in dot-notation (#12095) (Milos Djermanovic)
3e5ceca Fix: Handle empty string property names in getFunctionNameWithKind (#12104) (Milos Djermanovic)
9a043ff Fix: no-duplicate-case false positives on Object.prototype keys (#12107) (Milos Djermanovic)
fe631af Chore: minor typo fix (#12112) (James George)
4cb7877 Fix: fix no-extra-parens ignores some nodes (#11909) (Pig Fang)
2dc23b8 Update: fix no-dupe-keys false negatives on empty string names (#12069) (Milos Djermanovic)
19ab666 Fix: yoda exceptRange false positives on empty string property names (#12071) (Milos Djermanovic)
d642150 Update: Check empty string property names in sort-keys (#12073) (Milos Djermanovic)
acce6de Fix: class-methods-use-this reports 'undefined' names (#12103) (Milos Djermanovic)
92ec2cb Fix: Allow bind call with a single spread element in no-extra-bind (#12088) (Milos Djermanovic)
bfdb0c9 Fix: no-extra-boolean-cast invalid autofix for Boolean() without args (#12076) (Milos Djermanovic)
34ccc0c Chore: Remove TDZ scope type condition from no-unused-vars (#12055) (Milos Djermanovic)
01d38ce Docs: Remove TDZ scope from the scope manager interface documentation (#12054) (Milos Djermanovic)
1aff8fc Update: warn about mixing ternary and logical operators (fixes #11704) (#12001) (Karthik Priyadarshan)
11be2f8 Docs: do not recommend global-installed usage (#12016) (薛定谔的猫)
cf31dab Fix: no-restricted-syntax - correct the schema (#12051) (Brad Zacher)
fbec99e Update: fix class-methods-use-this false negatives with exceptMethods (#12077) (Milos Djermanovic)
fb08b7c Docs: Remove readonly/writable global logic from no-undef (fixes #11963) (#12053) (Milos Djermanovic)
5b5934b Sponsors: Sync README with website (ESLint Jenkins)
9156760 Sponsors: Sync README with website (ESLint Jenkins)
f5e0cc4 Update: Check computed method keys in no-extra-parens (#11973) (Milos Djermanovic)
d961438 Docs: Fix Incorrect Documentation (#12045) (Michael Miceli)
887d08c Sponsors: Sync README with website (ESLint Jenkins)
d90183f Docs: add a case to func-names (#12038) (Chiawen Chen)
8a5b62d Docs: no use eslint.linter in code example (#12037) (薛定谔的猫)
5831767 Update: report location of func-names (fixes #12022) (#12028) (Pig Fang)

Commits

The new version differs by 33 commits.

320b7bd 6.2.0
9601f5a Build: changelog update for 6.2.0
fee6acb Update: support bigint and dynamic import (refs #11803) (#11983)
afd8012 New: noInlineConfig setting (refs eslint/rfcs#22) (#12091)
3d12378 Update: Fix accessor-pairs to enforce pairs per property in literals (#12062)
8cd00b3 New: function-call-argument-newline (#12024)
30ebf92 Fix: prefer-template autofix produces syntax error with octal escapes (#12085)
13c3988 Fix: Check literal type explicitly in dot-notation (#12095)
3e5ceca Fix: Handle empty string property names in getFunctionNameWithKind (#12104)
9a043ff Fix: no-duplicate-case false positives on Object.prototype keys (#12107)
fe631af Chore: minor typo fix (#12112)
4cb7877 Fix: fix no-extra-parens ignores some nodes (#11909)
2dc23b8 Update: fix no-dupe-keys false negatives on empty string names (#12069)
19ab666 Fix: yoda exceptRange false positives on empty string property names (#12071)
d642150 Update: Check empty string property names in sort-keys (#12073)

There are 33 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

An in-range update of eslint-plugin-import is breaking the build 🚨

Version 2.4.0 of eslint-plugin-import just got published.

Branch	Build failing 🚨
Dependency	eslint-plugin-import
Current Version	2.3.0
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint-plugin-import is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Commits

The new version differs by 10 commits.

44ca158 update utils changelog
a3728d7 bump eslint-module-utils to v2.1.0
3e29169 bump v2.4.0
ea9c92c Merge pull request #737 from kevin940726/master
8f9b403 fix typos, enforce type of array of strings in allow option
95315e0 update CHANGELOG.md
28e1623 eslint-module-utils: filePath in parserOptions (#840)
2f690b4 update CI to build on Node 6+7 (#846)
7d41745 write doc, add two more tests
dedfb11 add allow glob for rule no-unassigned-import, fix #671

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

prefer-arrow-callback: [ "error", { "allowNamedFunctions": true } ]

This allows following style:

const ComponentName = memo(function ComponentName() {

});

To avoid showing <<anonymous>> or Unknown as component name.

ref: https://eslint.org/docs/rules/prefer-arrow-callback

    'import/no-extraneous-dependencies': ['error', {
      devDependencies: [
        '**/__tests__/*.spec.js',
        '**/__stories__/*.story.js',
        'scripts/*.js',
        'webpack.config.*.js',
      ],
    }],

https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md#options

應該只有 test 會多用到 devDependencies?

"comma-dangle": ["error", {
  "arrays": "always-multiline",
  "objects": "always-multiline",
  "imports": "always-multiline",
  "exports": "always-multiline",
  "functions": "ignore"
}]

如果不這樣改的話

const echoJSON = json =>
  enhanceFetch(
    () => Promise.resolve({
      status: 200,
      json: () => Promise.resolve(json),
    })
  //  ^ 這裡要加逗點不然會報錯
  );

yoctol / eslint-config-yoctol-base Goto Github PK

eslint-config-yoctol-base's People

Contributors

Stargazers

Watchers

Forkers

eslint-config-yoctol-base's Issues

The devDependency eslint-plugin-import was updated from 2.18.0 to 2.18.1.

The dependency eslint-config-prettier was updated from 6.0.0 to 6.1.0.

Open

Detected dependencies

The devDependency eslint was updated from 5.15.3 to 5.16.0.

The devDependency eslint was updated from 6.1.0 to 6.2.0.

Version 2.4.0 of eslint-plugin-import just got published.

Recommend Projects

Recommend Topics

Recommend Org

Jobs

The devDependency eslint-plugin-import was updated from `2.18.0` to `2.18.1`.

The dependency eslint-config-prettier was updated from `6.0.0` to `6.1.0`.

The devDependency eslint was updated from `5.15.3` to `5.16.0`.

The devDependency eslint was updated from `6.1.0` to `6.2.0`.