GithubHelp home page GithubHelp logo

Comments (8)

mathomp4 avatar mathomp4 commented on June 7, 2024 1

Well I feel stupid. I kept staring at the complex stuff below.

It does work! I wish there was a good way to see the "You need different flags" text on the PR page rather than having to drill down into the Actions tab. Not sure why github can't just make that bit of the "Review required" box bigger! or expandable.

But, if do go to the Checks tab I do see in the run step:

##[error]Select at least one label ['bug','enhancement','wontfix']
##[error]Select at least one label ['required']

Woot!

(Though, I've always wondered how GitGuardian gets that nice pretty page. My guess: money 😄 )

from enforce-label-action.

yogevbd avatar yogevbd commented on June 7, 2024

It does have the same functionality now 😊.
You can easily move to Github Actions by adding the yml file as described in the Readme file.
Let me know if you encounter issues or missing functionality. Thanks!

from enforce-label-action.

mathomp4 avatar mathomp4 commented on June 7, 2024

@yogevbd Ooh. Nice. Thanks. I'll try it out. There might be some more thoughts coming maybe based on this: dimagi/required-labels#28 (i.e., some way to tell people they should add a label x, y, z...)

But until then, I think I'm stupid/newbie. I'm trying it out here but it doesn't seem to mind I don't have any labels: mathomp4/labeltest-github-actions#2

from enforce-label-action.

yogevbd avatar yogevbd commented on June 7, 2024

The readme file was misleading.. sorry for the inconvenience.
Created a pull request in mathomp4/labeltest-github-actions#3 with the fix.
And it's defiantly possible and easy to add description labels.. will add it soon.

from enforce-label-action.

yogevbd avatar yogevbd commented on June 7, 2024

Added check run failure description support. See the updated Readme file.

from enforce-label-action.

mathomp4 avatar mathomp4 commented on June 7, 2024

@yogevbd Sorry for being out of touch on this. Work has been...worky. But I'm back on it. I tried updating my .github/workflows/enforce-labels.yml but I seem to have broken something. When I made a test PR at mathomp4/labeltest-github-actions#4 it's happy with no labels at all.

Any ideas what I might have done wrong?

from enforce-label-action.

yogevbd avatar yogevbd commented on June 7, 2024

The syntax was wrong. I suggested a fix in mathomp4/labeltest-github-actions#5

from enforce-label-action.

mathomp4 avatar mathomp4 commented on June 7, 2024

As I try to clean up, I can definitely say @yogevbd helped me out with this. I will close.

Though fair warning to @yogevbd, I am looking at label actions again... 😄

from enforce-label-action.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.