yogevbd / enforce-label-action

Hi there 👋

Latest blog posts:

• Best practices for Push Notifications in React Native

Connect with me:

enforce-label-action's Issues

Include option for enforceOneOfSet

The post-merge version label actions we use throws an error if more than one version label is present on the PR.
It would be useful to have an option that allows us to enforce only one selection of a label from a given set in a pre-merge check.

Possibly replace required-labels?

A query for the dev. Do you think this action could (eventually) replace my reliance on https://github.com/dimagi/required-labels If there's a way to use Github Actions instead of Heroku, it sounds like a good thing to me.

But, am I right in my reading that this doesn't yet have all the same functionality?

Possible bug when assigning multiple labels at once

In this PR I've assigned 3 labels at once via a cli client. The action rejected this at first although one of the labels do fit the required list. After removing and re-adding the "pr:fix" label the action went through OK.

Action Failing in Setup

Maybe from npm update recently since this dockerfile isn't pinned to a node:slim version

Build container for action use: '/home/runner/work/_actions/yogevbd/enforce-label-action/2.1.0/Dockerfile'.
  /usr/bin/docker build -t 1e5c35:7e9a42bda5f342b6826dfc8bf138c073 -f "/home/runner/work/_actions/yogevbd/enforce-label-action/2.1.0/Dockerfile" "/home/runner/work/_actions/yogevbd/enforce-label-action/2.1.0"
  Sending build context to Docker daemon  34.82kB
  
  Step 1/5 : FROM node:slim
  slim: Pulling from library/node
  babf97a3f00a: Pulling fs layer
  d81eb1809d95: Pulling fs layer
  54b0718e1fd5: Pulling fs layer
  9f80bf52a6c0: Pulling fs layer
  28724063fd29: Pulling fs layer
  9f80bf52a6c0: Waiting
  28724063fd29: Waiting
  d81eb1809d95: Verifying Checksum
  d81eb1809d95: Download complete
  babf97a3f00a: Verifying Checksum
  babf97a3f00a: Download complete
  54b0718e1fd5: Verifying Checksum
  54b0718e1fd5: Download complete
  28724063fd29: Verifying Checksum
  28724063fd29: Download complete
  9f80bf52a6c0: Verifying Checksum
  9f80bf52a6c0: Download complete
  babf97a3f00a: Pull complete
  d81eb1809d95: Pull complete
  54b0718e1fd5: Pull complete
  9f80bf52a6c0: Pull complete
  28724063fd29: Pull complete
  Digest: sha256:a39f2854f7fc02c8636c11227ca2d6680bd46a2173168650928b69cc03dffb1c
  Status: Downloaded newer image for node:slim
   ---> 2870b8b46426
  Step 2/5 : COPY . .
   ---> 25ccac34cace
  Step 3/5 : RUN npm install
   ---> Running in e42b56ada35b
  npm notice 
  npm notice New patch version of npm available! 7.0.2 -> 7.0.3
  npm notice Changelog: <https://github.com/npm/cli/releases/tag/v7.0.3>
  npm notice Run `npm install -g [email protected]` to update!
  npm notice 
  npm ERR! Maximum call stack size exceeded
  
  npm ERR! A complete log of this run can be found in:
  npm ERR!     /root/.npm/_logs/2020-10-22T20_11_22_688Z-debug.log
  The command '/bin/sh -c npm install' returned a non-zero code: 1
  
  Warning: Docker build failed with exit code 1, back off 5.674 seconds before retry.
  /usr/bin/docker build -t 1e5c35:7e9a42bda5f342b6826dfc8bf138c073 -f "/home/runner/work/_actions/yogevbd/enforce-label-action/2.1.0/Dockerfile" "/home/runner/work/_actions/yogevbd/enforce-label-action/2.1.0"
  Sending build context to Docker daemon  34.82kB
  
  Step 1/5 : FROM node:slim
   ---> 2870b8b46426
  Step 2/5 : COPY . .
   ---> Using cache
   ---> 25ccac34cace
  Step 3/5 : RUN npm install
   ---> Running in bef7a0bd6a8e
  npm notice 
  npm notice New patch version of npm available! 7.0.2 -> 7.0.3
  npm notice Changelog: <https://github.com/npm/cli/releases/tag/v7.0.3>
  npm notice Run `npm install -g [email protected]` to update!
  npm notice 
  npm ERR! Maximum call stack size exceeded
  
  npm ERR! A complete log of this run can be found in:
  npm ERR!     /root/.npm/_logs/2020-10-22T20_11_29_484Z-debug.log
  The command '/bin/sh -c npm install' returned a non-zero code: 1
  
  Warning: Docker build failed with exit code 1, back off 8.691 seconds before retry.
  /usr/bin/docker build -t 1e5c35:7e9a42bda5f342b6826dfc8bf138c073 -f "/home/runner/work/_actions/yogevbd/enforce-label-action/2.1.0/Dockerfile" "/home/runner/work/_actions/yogevbd/enforce-label-action/2.1.0"
  Sending build context to Docker daemon  34.82kB
  
  Step 1/5 : FROM node:slim
   ---> 2870b8b46426
  Step 2/5 : COPY . .
   ---> Using cache
   ---> 25ccac34cace
  Step 3/5 : RUN npm install
   ---> Running in dafd0a28c9fa
  npm notice 
  npm notice New patch version of npm available! 7.0.2 -> 7.0.3
  npm notice Changelog: <https://github.com/npm/cli/releases/tag/v7.0.3>
  npm notice Run `npm install -g [email protected]` to update!
  npm notice 
  npm ERR! Maximum call stack size exceeded
  
  npm ERR! A complete log of this run can be found in:
  npm ERR!     /root/.npm/_logs/2020-10-22T20_11_39_400Z-debug.log
  The command '/bin/sh -c npm install' returned a non-zero code: 1
  
Error: Docker build failed with exit code 

create an example .yml file

you should provide an example yml file

Rerun not working

Hi @yogevbd. Thanks for this, works great! The only thing I haven't been able to figure out is why I can't "rerun" after adding a label. The only way I can get this to pass is by re-pushing code. Re-running seems to work, but pulls a cached version of the labels. Any idea?

Add v-prefixed tags for releases

Releases are named with a "v" prefix e.g. "v2.2.2" but the underlying Git tag does not have it. It's common for the tag itself to match and makes references in Actions, dependency update tools, etc. to be more consistent with other projects.

Requesting the creation of new tags for the past releases or at least the latest, and to use that pattern going forward (or both).