yousafe007 / blockchain-developer-bootcamp-final-project Goto Github PK

Hi @yousafe007, I am a mentor helping with the grading process.
Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend

• Great job with the frontend of the covid certificate verification and submission project.
• You also have a good readme file and a good demo video that helped in testing the frontend of the application.
• Your front end passed the requirement but just in case you want to improve on it, you may need to make your dapp detect account change because account change is not currently detected by the dapp.
• Good job with the deployment to Github pages as its easy to get a basic MVP version up and running.

Smart contract

• Well commented with concise smart contract code that implements basic design patterns and security features.

Tests

• Well written test code that covers most of the important functions of the
  contract

Design and Security

• Good job with the use of Access control, inheritance, pausable feature in case of emergency, and also the use of ownership in your design pattern.
• Good job with the use of a recent version of Solidity compiler. using the same pragma to test contracts, using modifiers to validate application logic, and also avoiding requirement violation.