yuhanfang / riot Goto Github PK

Use the MarshalJSON / UnmarshalJSON interface. Example here:

https://gist.github.com/alexmcroberts/219127816e7a16c7bd70

https://na1.api.riotgames.com/lol/league/v4/masterleagues/by-queue/RANKED_SOLO_5x5

The league endpoints seem to no longer return playerOrTeamId or playerOrTeamName, only summonerId and summonerName.

masters, err := app.RiotAPI.GetMasterLeague(app.Context, region, queue.RankedSolo5x5)

 "entries": [
        {
            "summonerName": "qeqeqeqe",
            "hotStreak": false,
            "wins": 79,
            "veteran": false,
            "losses": 64,
            "rank": "I",
            "inactive": false,
            "freshBlood": true,
            "summonerId": "encryptedString",
            "leaguePoints": 12
        },
]

Not submitting a PR with this since my initial idea was to just change the field names, but that breaks backward compatibility (not painful at all though, easy name replaces). Submitted PR

Need to implement stats and stats timeline APIs for the esports API. This is a matter of figuring out the JSON schema and go-ifying it.

The structs returned by the esports API don't currently include all of the JSON fields in the HTTP response. This is partly because the documentation is lacking, and partly because the current fields are enough to query for game data, which is more of the focus.

Contributions are welcome to add more missing fields.

Region is not explicitly returned by the API, but it should be returned for convenience. Otherwise, the user often has to track the tuple (region, return value).

Hi,

using this test code.

champs, _ := riotClient.GetChampions(ctx, region.EUW1)
log.Println(champs)

where the riotClient has a valid API Key and a call like

summoner, err := riotClient.GetBySummonerName(ctx, region.EUW1, "Gibbs123") // My Account

returns a valid response, the GetChampions does in fact return &{[]} as log.println'd

Is this fixable?

https://discussion.developer.riotgames.com/articles/3779/runes-reforged-changes-in-the-riot-games-api.html

Waiting for official docs to update (probably after preseason), and for new static data endpoints

Migrate from dep to go modules (vgo).

Go modules are built right into go and is extremely easy to use.

see pr #36