zackhsi / fzf-tags

:cherry_blossom: :microscope:

zackhsi

This repository configures http://zackhsi.com and its subdomains. Routing is managed with nginx.

Currently, the server:

• proxies http://zackhsi.com -> zackhsi.github.io
• proxies http://kegbot.zackhsi.com -> EC2 instance

fzf-tags's Issues

Can I change default color?

By default fzf uses vim scheme color. In fzf-tags, you set color in code.
Is there any trick for me to change the color? Thank you!

Feature request: Inherit default FZF layout

Hi, thanks for the plugin.

FZF recently switched to floating pop-up window by default (It works in my NeoVIM 0.4.4), but fzf-tags use predefined { 'down': '~40%' }. Because I use both native FZF functionality and your plugin I found it useful to have same layout.

Would be great if fzf-tags can inherit the same default layout that is used in FZF.

For now I just hard-coded floating window

diff --git a/autoload/fzf_tags.vim b/autoload/fzf_tags.vim
index 06033d4..ec73898 100644
--- a/autoload/fzf_tags.vim
+++ b/autoload/fzf_tags.vim
@@ -40,7 +40,7 @@ function! fzf_tags#Find(identifier)
     \   'source': source_lines,
     \   'sink*':   function('s:sink', [identifier]),
     \   'options': '--expect=' . expect_keys . ' --ansi --no-sort --tiebreak index --prompt "' . g:fzf_tags_prompt . '\"' . identifier . '\" > "',
-    \   'down': '40%',
+    \   'window' : { 'width': 0.9, 'height': 0.6, 'highlight': 'Normal' },
     \ })
   endif
 endfunction

Example floating window

[Bug] FZFTselect not working properly

When I place my cursor in normal mode on a word, :FZFTselect leads to this:

First thing I notice is that no tag line or kind information are reported.

Secondly, when I select one of the two entries pressing Enter, then the following appears:

As if FZFTselect didn't activate any tag.

My expected behavior is:

Ctrl+] on a word. If it is the only tag definition, jump to it (this actually works). In case of multiple occurrences of it, then open the FZF filter window, select one of the reported tags, press Enter (or similar key) and jump directly on it. This is unfortunately not happening in my setup.

fzftselect supports tag completion

hi, I noticed fzftselect doesn't have tab completion as the builtin tselect has. so if I type in a partial tag name then press tab, vim's tselect gives me all tags matching the prefix so far without selecting/committing any of them, just like bash tab completion, whereas with fzftselect, I just get a ^I symbol (the literal tab char?) on the command line, which is somewhat inconvenient, since I didn't get the completions, and I have to remove the unintended ^I. this prevents fzftselect as a dropin replacement to the builtin tselect. any chance to have fzftselect behaves the same here? thanks.

"E684: list index out of range: 0" when <C-c> in fzf

If you <C-]> / <Plug>(fzf_tags) on a tag with multiple options, then <C-c> without selecting an option in FZF, vim will barf with the following error message:

Error detected while processing function fzf_tags#FindCommand[1]..fzf_tags#Find[12]..fzf#run[69]..<SNR>24_callback:
line   21:
Vim(let):E684: list index out of range: 0
Error detected while processing function fzf_tags#FindCommand[1]..fzf_tags#Find:
line   12:
E171: Missing :endif

I instead expect FZF / fzf-tags to exit without an error and without jumping me anywhere.

I'm pretty bad at vimscript, but adding the following to the top of s:sink seems to fix the problem:

  if len(a:selection) == 0
    return
  end

FZF tags selects wrong file

When there are several tags, FZF selection ends up in wrong file.
for ex., if workspace has id1 defined in foo1.cpp, foo2.cpp, foo3.cpp .. foo30.cpp

FZF tags menu shows all 30 files. However if i select foo2.cpp, vim would bring up some other file, like foo10.cpp for ex.

Why use `--no-sort`?

I'm curious why sorting is disabled when searching within the results? I personally find it inconvenient. Was there any particular reason behind using --no-sort?

Link: https://github.com/zackhsi/fzf-tags/blob/master/autoload/fzf_tags.vim#L23

[Request] Add preview of tag

Similar to the fzf :Tags command, can you add a preview of the file positioned on the tag definition?

I'm thinking you can call fzf#run with fzf#vim#with_preview({ "placeholder": "--tag {2}:{-1}:{3}" } similar to what :Tags does. But the source lines need to have the tagfile path in addition to what you already construct.

Cancelling triggers an error

Hello,
When using fzf-tags, if I hit esc, I have an error E684 while processing function 29_callback.
I wish that it would silently return to my previous context before.

Thanks for creating this functionality, I wish the default fzf worked as well as yours