zakenobi / cryptech Goto Github PK

When the app is started, it has the default GTK theme of the shell. However, if the user selects the option dark in the Affichage menu, the theme is changed to a custom one (dark or light), and cannot be changed back.

Debug lines are printed when doing a job:

choix = 1
prog=0,769231
prog=1,538462

If these lines represent the advancement of encrypting (or decrypting) the files, they shouldn't be over 1 (100%).

File names' should indicate what they contain: how can you know what does crypt1.h contains without opening it?
They should rather be:
crypt1.h → caesar.h
crypt2.h → poly_alph.h
crypt3.h → vigenere.h

In the same way, functions' name should explain what they do: what is cesar_normal() when there is ceaser_crypt()?
I thus suggest to rename all the "_normal" functions to "_decrypt".

Steps to reproduce

1. Create a file;
2. Open it as a source file in the app;
3. Set the target file with an existing file.

Expected behaviour

Target file should be written over.

Actual behaviour

The cypher (or de-cypher) text is appended to the end of the target file.

The buttons of the menu bar (apart from Affichage>dark) do nothing when clicked.
They should be removed if they have no purpose.