zao / gorilla-audio Goto Github PK

dst[i] += (gc_int32)((gc_int32)src[j] * gain * (1.0f - pan) * 2);
dst[i + 1] += (gc_int32)((gc_int32)src[j + ((srcChannels == 1) ? 0 : 1)] * gain 
* pan * 2);

Should be:

gc_float32 lmul = gain * (pan < 0.5 ? 1 : (1 - pan) * 2);
gc_float32 rmul = gain * (pan > 0.5 ? 1 : pan * 2);
dst[i] += (gc_int32)((gc_int32)src[j] * lmul);
dst[i + 1] += (gc_int32)((gc_int32)src[j + ((srcChannels == 1) ? 0 : 1)] * 
rmul);

So, the * 2 was causing loud noises to cut out when panned. 

What steps will reproduce the problem?
1. Make the library
2. Note warning: 
WARNING: While resolving call to function 'gaX_stream_link_create' arguments 
were dropped!

What is the expected output? What do you see instead?
gaX_stream_manager_add (ga_stream.c:144) creates a gaX_StreamLink, passing it 
in_stream. However, gaX_stream_link create accepts no arguments. This causes 
the warning.

I see that streamLink->stream is set on line 150 of the same function, so this 
shouldn't affect the library functionally.

What version of the product are you using? On what operating system?
0.3.0 archive.

Please provide any additional information below.
Patch is attached.

I implemented positional audio on top of gorilla, but get audio crackles when 
the pan of a handle changes. How do I mitigate that?

Just a long-term suggestion and enhancement: add support for Opus audio.

It's an extremely low-latency audio codec, and basically the successor to 
Vorbis. Also comes free-of-charge, open-sourced and even been IETF-standardised.

More info at http://opus-codec.org/ and irc://irc.freenode.net/daala

What steps will reproduce the problem?
1. Compile from sources
2. Run example-tone

What is the expected output? What do you see instead?

Some panning is expected in the output audio


What version of the product are you using? On what operating system?

GorillaAudio-0.3.0-src, on Ubuntu 12.10 64bit and OpenAL 1.14 backend


Please provide any additional information below.

Output buffer before sending to dev seems to be ok panned

What steps will reproduce the problem?
1. cd build/
2. cmake .
3. make

What is the expected output? What do you see instead?
Expected: 
Builds library.

Actual: 
Scanning dependencies of target gorilla
[  3%] Building C object 
CMakeFiles/gorilla.dir/Users/justin/Downloads/GorillaAudio-0.3.0-src/src/ga.c.o
[  7%] Building C object 
CMakeFiles/gorilla.dir/Users/justin/Downloads/GorillaAudio-0.3.0-src/src/gau.c.o
/Users/justin/Downloads/GorillaAudio-0.3.0-src/src/gau.c:31: error: 
redefinition of typedef ‘gau_Manager’
/Users/justin/Downloads/GorillaAudio-0.3.0-src/build/../include/gorilla/gau.h:38
: error: previous declaration of ‘gau_Manager’ was here
make[2]: *** 
[CMakeFiles/gorilla.dir/Users/justin/Downloads/GorillaAudio-0.3.0-src/src/gau.c.
o] Error 1
make[1]: *** [CMakeFiles/gorilla.dir/all] Error 2
make: *** [all] Error 2


What version of the product are you using? On what operating system?
Version 0.3.0 downloaded archive. CMake 2.8.9. Xcode 4.5.2

Please provide any additional information below.

Let me know if I can provide any additional information.